new: resolve NPE in NetHandlerPlayClient#handleSpawnPlayer (#152)

Sk1erLLC · Jul 12, 2023 · 4090c17 · 4090c17
1 parent e296904
commit 4090c17
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 0 deletions.
diff --git a/...java/club/sk1er/patcher/mixins/bugfixes/NetHandlerPlayClient_FixHandleSpawnPlayerNPE.java b/...java/club/sk1er/patcher/mixins/bugfixes/NetHandlerPlayClient_FixHandleSpawnPlayerNPE.java
@@ -0,0 +1,35 @@
+package club.sk1er.patcher.mixins.bugfixes;
+
+import net.minecraft.client.network.NetHandlerPlayClient;
+import net.minecraft.client.network.NetworkPlayerInfo;
+import net.minecraft.network.play.server.S0CPacketSpawnPlayer;
+import org.spongepowered.asm.mixin.Mixin;
+import org.spongepowered.asm.mixin.Shadow;
+import org.spongepowered.asm.mixin.injection.At;
+import org.spongepowered.asm.mixin.injection.Inject;
+import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
+
+import java.util.UUID;
+
+@Mixin(NetHandlerPlayClient.class)
+public abstract class NetHandlerPlayClient_FixHandleSpawnPlayerNPE {
+
+    @Shadow
+    public abstract NetworkPlayerInfo getPlayerInfo(UUID p_175102_1_);
+
+    @Inject(
+        method = "handleSpawnPlayer",
+        cancellable = true,
+        at =
+        @At(
+            value = "INVOKE",
+            target = "Lnet/minecraft/network/PacketThreadUtil;checkThreadAndEnqueue(Lnet/minecraft/network/Packet;Lnet/minecraft/network/INetHandler;Lnet/minecraft/util/IThreadListener;)V",
+            shift = At.Shift.AFTER
+        ))
+    private void patcher$fixHandleSpawnPlayerNPE(S0CPacketSpawnPlayer packetIn, CallbackInfo ci) {
+        if (this.getPlayerInfo(packetIn.getPlayer()) == null) {
+            ci.cancel();
+        }
+    }
+
+}
diff --git a/src/main/resources/patcher.mixins.json b/src/main/resources/patcher.mixins.json
@@ -68,6 +68,7 @@
     "bugfixes.MinecraftMixin_FixScreenState",
     "bugfixes.MinecraftMixin_ForeignKeyboards",
     "bugfixes.MinecraftMixin_PersistentShaders",
+    "bugfixes.NetHandlerPlayClient_FixHandleSpawnPlayerNPE",
     "bugfixes.RenderPlayerMixin_ArmPosition",
     "bugfixes.ScoreboardMixin_FixLogSpam",
     "bugfixes.SoundManagerMixin_DuplicatedSounds",

diff --git a/versions/1.12.2-1.8.9.txt b/versions/1.12.2-1.8.9.txt
@@ -41,6 +41,7 @@ net.minecraft.network.play.server.SPacketEntityHeadLook net.minecraft.network.pl
 net.minecraft.network.play.server.SPacketEntityStatus net.minecraft.network.play.server.S19PacketEntityStatus
 net.minecraft.network.play.server.SPacketCloseWindow net.minecraft.network.play.server.S2EPacketCloseWindow
 net.minecraft.network.play.server.SPacketCustomPayload net.minecraft.network.play.server.S3FPacketCustomPayload
+net.minecraft.network.play.server.SPacketSpawnPlayer net.minecraft.network.play.server.S0CPacketSpawnPlayer
 net.minecraft.network.status.client.CPacketServerQuery net.minecraft.network.status.client.C00PacketServerQuery
 net.minecraft.network.status.server.SPacketServerInfo net.minecraft.network.status.server.S00PacketServerInfo
 net.minecraft.network.status.server.SPacketPong net.minecraft.network.status.server.S01PacketPong