Chart aggregate and discrete session usage #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhamon
commented
Jun 13, 2023
andrewhamon
force-pushed
the
add-session-metrics
branch
from
04c2842 to
6f00f0b
Compare
Currently, CurrentSessions is completely ignored. This makes it hard to measure overall utilization. This PR adds two new metrics: passenger.process.sessions - the number of sessions for a discrete process passenger.sessions.total - the sum of sessions for the entire host I'm not sure both are strictly necessary, but I am trying to match the existing metrics as closely as possible.
andrewhamon
force-pushed
the
add-session-metrics
branch
from
6f00f0b to
9dbc8af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, CurrentSessions is completely ignored. This makes it hard to measure overall utilization.
This PR adds two new metrics:
passenger.process.sessions - the number of sessions for a discrete process
passenger.sessions.total - the sum of sessions for the entire host
I'm not sure both are strictly necessary, but I am trying to match the existing metrics as closely as possible.