Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule and reference updates #45

Merged
merged 3 commits into from
Jan 21, 2024
Merged

Rule and reference updates #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1497a32
Add AOT compatibility property
JimBobSquarePants Jan 21, 2024
0d48f38
Add primary constructor rule
JimBobSquarePants Jan 21, 2024
6268294
Update Xunit
JimBobSquarePants Jan 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,8 @@ dotnet_diagnostic.IDE0063.severity = suggestion
csharp_using_directive_placement = outside_namespace:warning
# Modifier preferences
csharp_prefer_static_local_function = true:warning
# Primary constructor preferences
csharp_style_prefer_primary_constructors = false:none

##########################################
# Unnecessary Code Rules
Expand Down
3 changes: 2 additions & 1 deletion msbuild/props/SixLabors.Src.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,12 @@
<RepositoryType>git</RepositoryType>
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<IsAotCompatible>true</IsAotCompatible>
</PropertyGroup>

<!--
Define Environmental conditionals. Determined by environmental settings set in build-and-test.yml
These proeprties are defined 2X to ensure both MSBuild and Visual Studio (preprocessor directives)
These properties are defined 2X to ensure both MSBuild and Visual Studio (preprocessor directives)
can correctly detect them.
-->
<PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion msbuild/props/SixLabors.Tests.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<!-- Package references and additional files which are consumed by test projects -->
<ItemGroup Condition="'$(IsTestProject)' == 'true'">
<PackageReference Include="xunit" Version="2.6.5" IsImplicitlyDefined="true" />
<PackageReference Include="xunit" Version="2.6.6" IsImplicitlyDefined="true" />

<PackageReference Include="coverlet.collector"
Version="6.0.0"
Expand Down
Loading