[sitecore-jss-nextjs]: Recommending fix to minimized React 18 warnings with nextjs & defaultProps errors #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sengert-alliance
changed the title
|
Would be nice if the Sitecore team could backport this into v20 release, too, for those that are stuck on it for now :) alternatively, would you accept PRs to fix v20 versions as well @ambrauer ? |
sengert-alliance
changed the title
yavorsk
added
the
backlog
|
@yavorsk is there any way that this can be expedited? |
|
@sengert-alliance I will bump now the priority of this and discuss to include it in the next hotfix for v21, thanks. |
|
In addition to
See the PR that fixed this for v22: #1784 |
…t props to elliminate react 18 defaultProps error
|
@coreyasmith I have migrated those changes to this PR as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…efaultProps errors
Description / Motivation
Field Components have been updated to solve issue with react 18 throwing warnings that defaultProps is deprecated.
This change is to update fields to alleviate defaultProps warnings caused by react 18 which was introduced in jss version 21.7.0 where nextjs was upgraded to next 14.
Testing Details
Ran existing tests to make sure that nothing broke
Types of changes