Skip to content

Commit

Permalink
FIX: SvgIcons scope
Browse files Browse the repository at this point in the history
  • Loading branch information
GrimLink committed Oct 11, 2024
1 parent bf980a3 commit 3511df4
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 7 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed
- Moved `SvgIcons` argument from global scope to frontend and adminthtml scope

## [2.1.2] - 2024-10-07
### Changed
- Update Lucide icons to v0.446
Expand Down
13 changes: 13 additions & 0 deletions etc/adminhtml/di.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?xml version="1.0"?>
<config
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd"
>
<type name="Hyva\Theme\ViewModel\SvgIcons">
<arguments>
<argument name="pathPrefixMapping" xsi:type="array">
<item name="lucide" xsi:type="string">Siteation_HyvaIconsLucide::svg/lucide</item>
</argument>
</arguments>
</type>
</config>
7 changes: 0 additions & 7 deletions etc/di.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,4 @@
<argument name="iconPathPrefix" xsi:type="string">Siteation_HyvaIconsLucide::svg/lucide</argument>
</arguments>
</type>
<type name="Hyva\Theme\ViewModel\SvgIcons">
<arguments>
<argument name="pathPrefixMapping" xsi:type="array">
<item name="lucide" xsi:type="string">Siteation_HyvaIconsLucide::svg/lucide</item>
</argument>
</arguments>
</type>
</config>
13 changes: 13 additions & 0 deletions etc/frontend/di.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?xml version="1.0"?>
<config
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd"
>
<type name="Hyva\Theme\ViewModel\SvgIcons">
<arguments>
<argument name="pathPrefixMapping" xsi:type="array">
<item name="lucide" xsi:type="string">Siteation_HyvaIconsLucide::svg/lucide</item>
</argument>
</arguments>
</type>
</config>

0 comments on commit 3511df4

Please sign in to comment.