Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ability to create a copy of the TexasHoldEm object #199

Merged
merged 3 commits into from
Jun 18, 2023
Merged

Conversation

SirRender00
Copy link
Owner

Prerelease for #196

@SirRender00 SirRender00 added this to the v1.0.0 milestone Jun 18, 2023
@SirRender00 SirRender00 added the enhancement New feature or request label Jun 18, 2023
@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Merging #199 (0c7b004) into main (23fe7c5) will decrease coverage by 0.26%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
- Coverage   91.52%   91.27%   -0.26%     
==========================================
  Files          18       18              
  Lines        1121     1169      +48     
==========================================
+ Hits         1026     1067      +41     
- Misses         95      102       +7     
Impacted Files Coverage Δ
texasholdem/game/game.py 93.37% <80.48%> (-0.97%) ⬇️
texasholdem/card/deck.py 97.05% <100.00%> (+0.76%) ⬆️

Copy link
Contributor

@LucasColas LucasColas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks interesting. Does this work whatever the state of the hand ? (Preflop, Flop, Turn, River).
Also does this keep the right game turn ?

@SirRender00
Copy link
Owner Author

That looks interesting. Does this work whatever the state of the hand ? (Preflop, Flop, Turn, River). Also does this keep the right game turn ?

Yes. For now this does what we want: it will copy the basic attributes of the TexasHoldEm object and then replays the last hand so that the generators are in the correct state.

A better future implementation would somehow be able to copy attributes directly without needing to replay the previous hand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants