Extend snarkjs testing #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test invoking all of the commands in
snarkjs --help.The new files in
snark_js/circom_fileswere generated by Circom v2.1.5 (not the latest release, but close enough). I have considered the possibility that Circom & Snarkjs undergo an update, introducing errors in the test script from our outdated serializations incircom_files/. Informally, I'd estimate the likelihood is low. I've never encountered or heard about snarkjs breaking changes. There are enough Circom circuits in production use cases out there, I suspect they develop around backwards compatibilitySince the test script generates so many intermediate files - I created
/tmp/snarkjsat the beginning of the script and remove it at the end. There are plenty of subdirectories added to this folder, but I never bother to delete them. I let the recursive flag handle all that at the end. Just pointing this out in case there is a reason not to do that (iftest.shends early, many intermediate files are left).