Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 issue #261 userReactionCallback not working #272

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

vatsaltanna
Copy link
Collaborator

@vatsaltanna vatsaltanna commented Nov 1, 2024

Description

Fixes #261 : ConfigurationsInheritedWidget was out of scope in ReactionPopup, which prevented userReactionCallback from triggering.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@vatsaltanna vatsaltanna linked an issue Nov 1, 2024 that may be closed by this pull request
@vatsaltanna vatsaltanna merged commit 771a35e into main Nov 1, 2024
@vatsaltanna vatsaltanna deleted the bugfix/issue_261 branch November 1, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants