refactor: Improve re-install timer to address OS update issues #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…educe the likelihood of failure to execute
…rvice initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements several improvements in an attempt to resolve the OS update issues some folks have been reporting. It does so through three key changes:
It adds a
RequiresMountsFor=/data/tailscalerequirement to thetailscale-install.serviceto clarify sequencing requirements for the OS.It updates the install script to ensure that the install timer and service are always enabled after running the installer (to prevent cases where these might have been installed but not enabled).
It updates the configuration of the timer and service to provide better linking and follow the recommended systemd timer format for recurring jobs, which should avoid scenarios where the installer might not run correctly.
I have tested this on a UDM, however it has not yet been tested on other devices.