Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange Rate route 500s #165

Closed
telestrial opened this issue Feb 4, 2025 · 5 comments
Closed

Exchange Rate route 500s #165

telestrial opened this issue Feb 4, 2025 · 5 comments

Comments

@telestrial
Copy link

It appears that a few of these work but many do not. I'm getting 500 responses for the following currencies at the api/exchange-rate/siacoin/:currency mainnet route with a raw response failed to get exchange rate: no sources working:

  • cad
  • gbp
  • jpy
  • aud
  • cny
  • eth

What does seem to work:

  • usd
  • btc
  • eur
@telestrial telestrial added this to Sia Feb 4, 2025
@chris124567
Copy link
Member

chris124567 commented Feb 4, 2025

Kraken doesn't require an API key so we can give USD, BTC, and EUR to all users. For the other currencies, we need CoinGecko, which requires an API key.

Instance needs to be run like:

COINGECKO_API_KEY="xxxxx" go run ./cmd/explored

@telestrial
Copy link
Author

@n8maninger Is this something we're able to supply for our instance?

@n8maninger
Copy link
Member

Coingecko doesn't require an API key if you stay under their usage limits, but I've added a key to our node

@telestrial
Copy link
Author

So it sounds like we could build in some support for the free usage of Coingecko and handle the rate limit case by informing server and/or client--probably both?, but I'll leave those decisions to greater wisdom. I believe this issue has been resolved, as far as Explorer needs. Thank you both!

@n8maninger
Copy link
Member

@chris124567 #166

@github-project-automation github-project-automation bot moved this to Done in Sia Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants