use context for http requests in coingecko/kraken

SiaFoundation · Jan 15, 2025 · 1b2248c · 1b2248c
1 parent 7eb11c4
commit 1b2248c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/exchangerates/coingecko.go b/exchangerates/coingecko.go
@@ -35,11 +35,11 @@ func newcoinGeckoAPI(apiKey string) *coinGeckoAPI {
 type coinGeckoPriceResponse map[string]map[string]float64
 
 // See https://docs.coingecko.com/reference/simple-price
-func (k *coinGeckoAPI) ticker(currency, token string) (float64, error) {
+func (k *coinGeckoAPI) ticker(ctx context.Context, currency, token string) (float64, error) {
 	currency = strings.ToLower(currency)
 	token = strings.ToLower(token)
 
-	request, err := http.NewRequest(http.MethodGet, fmt.Sprintf("https://api.coingecko.com/api/v3/simple/price?vs_currencies=%s&ids=%s", currency, token), nil)
+	request, err := http.NewRequestWithContext(ctx, http.MethodGet, fmt.Sprintf("https://api.coingecko.com/api/v3/simple/price?vs_currencies=%s&ids=%s", currency, token), nil)
 	if err != nil {
 		return 0, err
 	}
@@ -98,7 +98,7 @@ func (c *coinGecko) Start(ctx context.Context) {
 		select {
 		case <-ticker.C:
 			c.mu.Lock()
-			c.rate, c.err = c.client.ticker(c.currency, c.token)
+			c.rate, c.err = c.client.ticker(ctx, c.currency, c.token)
 			c.mu.Unlock()
 		case <-ctx.Done():
 			c.mu.Lock()

diff --git a/exchangerates/kraken.go b/exchangerates/kraken.go
@@ -43,9 +43,14 @@ func newKrakenAPI() *krakenAPI {
 }
 
 // See https://docs.kraken.com/api/docs/rest-api/get-ticker-information
-func (k *krakenAPI) ticker(pair string) (float64, error) {
+func (k *krakenAPI) ticker(ctx context.Context, pair string) (float64, error) {
 	pair = strings.ToUpper(pair)
-	response, err := k.client.Get("https://api.kraken.com/0/public/Ticker?pair=" + url.PathEscape(pair))
+
+	request, err := http.NewRequestWithContext(ctx, http.MethodGet, "https://api.kraken.com/0/public/Ticker?pair="+url.PathEscape(pair), nil)
+	if err != nil {
+		return 0, err
+	}
+	response, err := k.client.Do(request)
 	if err != nil {
 		return 0, err
 	}
@@ -96,7 +101,7 @@ func (k *kraken) Start(ctx context.Context) {
 		select {
 		case <-ticker.C:
 			k.mu.Lock()
-			k.rate, k.err = k.client.ticker(k.pair)
+			k.rate, k.err = k.client.ticker(ctx, k.pair)
 			k.mu.Unlock()
 		case <-ctx.Done():
 			k.mu.Lock()