(feat): Add Positional Trait in Go codegen

.github/workflows/test_models_go_tests.yml

@@ -8,6 +8,7 @@ jobs:
       fail-fast: false
       matrix:
         library: [
+          # TODO: Uncomment below before making PR
           # TestModels/dafny-dependencies/StandardLibrary, # This stores current Polymorph dependencies that all TestModels depend on
           TestModels/Aggregate,
           # TestModels/AggregateReferences,
@@ -21,6 +22,7 @@ jobs:
           # TestModels/LanguageSpecificLogic,
           # TestModels/LocalService,
           # TestModels/MultipleModels,
+          TestModels/Positional,
           TestModels/Refinement,
           TestModels/Resource,
           # TestModels/SimpleTypes/BigDecimal,

TestModels/Positional/Makefile

@@ -16,6 +16,11 @@ SERVICE_DEPS_SimplePositional :=
 
 SMITHY_DEPS=dafny-dependencies/Model/traits.smithy
 
+GO_MODULE_NAME="github.com/Smithy-dafny/TestModels/Positional"
+
+PROJECT_DTR := \
+    dafny-dependencies/StandardLibrary/runtimes/go/ImplementationFromDafny-go/ImplementationFromDafny-go.dtr
+
 # This project has no dependencies 
 # DEPENDENT-MODELS:= 
 

TestModels/Positional/removeDotFromExtern.sh

@@ -0,0 +1,27 @@
+#!/bin/bash
+# TODO: remove this file if codegen is not generating extern with "." in go
+
+removeDotFromExtern() {
+  local directory="$1"
+  # Recursively search for all files in the current directory and subdirectories
+  for file in $(find "$directory" -type f); do
+      # Check if the file contains the pattern "{:extern "XYZ" }"
+      if grep -q '{:extern ".*"' "$file"; then
+          # Extract the "XYZ" part from the pattern
+          xyz=$(grep -o '{:extern "\([^"]*\)"' "$file" | sed 's/{:extern "\([^"]*\)"/\1/')
+          # Check if the "XYZ" part contains a dot
+          if [[ "$xyz" == *"."* ]]; then
+              # Remove the dot from "XYZ"
+              new_xyz=$(echo "$xyz" | sed 's/\.//g')
+              # Update the file with the new pattern
+              sed "s/{:extern \"$xyz\"/{:extern \"$new_xyz\"/g" $file > $file.tmp
+              cat $file.tmp > $file
+              rm $file.tmp
+          fi
+      fi
+  done
+}
+
+removeDotFromExtern "Model"
+removeDotFromExtern "src"
+

TestModels/Positional/runtimes/go/go.mod

@@ -0,0 +1,11 @@
+module github.com/Smithy-dafny/TestModels/Positional
+
+go 1.22.2
+
+require github.com/dafny-lang/DafnyStandardLibGo v0.0.0
+
+require github.com/dafny-lang/DafnyRuntimeGo v0.0.0
+
+replace github.com/dafny-lang/DafnyRuntimeGo => ../../../../../DafnyRuntimeGo/
+
+replace github.com/dafny-lang/DafnyStandardLibGo => ../../../../dafny-dependencies/StandardLibrary/runtimes/go/ImplementationFromDafny-go/

TestModels/SimpleTypes/SimpleEnum/src/Index.dfy

@@ -2,7 +2,7 @@
 // SPDX-License-Identifier: Apache-2.0
 include "SimpleEnumImpl.dfy"
 
-module {:extern "simpletypessmithyenuminternaldafny" } SimpleEnum refines AbstractSimpleTypesSmithyEnumService {
+module {:extern "simple.types.smithyenum.internaldafny" } SimpleEnum refines AbstractSimpleTypesSmithyEnumService {
     import Operations = SimpleEnumImpl
 
  function method DefaultSimpleEnumConfig(): SimpleEnumConfig {

TestModels/SimpleTypes/SimpleEnum/src/WrappedSimpleEnumImpl.dfy

@@ -2,7 +2,7 @@
 // SPDX-License-Identifier: Apache-2.0
 include "../Model/SimpleTypesSmithyEnumTypesWrapped.dfy"
 
-module {:extern "simpletypessmithyenuminternaldafnywrapped"} WrappedSimpleTypesEnumService refines WrappedAbstractSimpleTypesSmithyEnumService {
+module {:extern "simple.types.smithyenum.internaldafny.wrapped"} WrappedSimpleTypesEnumService refines WrappedAbstractSimpleTypesSmithyEnumService {
     import WrappedService = SimpleEnum
     function method WrappedDefaultSimpleEnumConfig(): SimpleEnumConfig {
         SimpleEnumConfig

codegen/smithy-dafny-codegen/src/main/java/software/amazon/polymorph/smithygo/codegen/StructureGenerator.java

@@ -112,6 +112,7 @@ public void renderStructure(Runnable runnable, boolean isInputStructure) {
 
                     if (targetShape.hasTrait(ReferenceTrait.class)) {
                         memberSymbol = memberSymbol.getProperty("Referred", Symbol.class).get();
+
                         var refShape = targetShape.expectTrait(ReferenceTrait.class);
                         if (refShape.isService()) {
                             namespace = SmithyNameResolver.shapeNamespace(model.expectShape(refShape.getReferentId()));
@@ -124,9 +125,7 @@ public void renderStructure(Runnable runnable, boolean isInputStructure) {
                             writer.addImportFromModule(SmithyNameResolver.getGoModuleNameForSmithyNamespace(targetShape.toShapeId().getNamespace()), namespace);
                         }
                     }
-
                     writer.write("$L $P", memberName, memberSymbol);
-
                 });
         writer.closeBlock("}").write("");
         renderValidator(symbol, sortedMembers, isInputStructure);