(feat): Add Positional Trait in Go codegen #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return dereferencableShapes.contains(shape.toShapeId()); | ||
| } | ||
| } | ||
| package software.amazon.polymorph.smithygo.codegen.knowledge; |
There was a problem hiding this comment.
What happened here? Why the whole file is in the diff??
There was a problem hiding this comment.
This diff will go away once I merge new changes to this PR.
| @@ -141,10 +144,20 @@ func NewClient(clientConfig $L) (*$T, error) { | |||
| if (inputShape.hasTrait(UnitTypeTrait.class)) { | |||
| baseClientCall = "var dafny_response = client.DafnyClient.%s()".formatted(operationShape.getId().getName()); | |||
| } else { | |||
| String dafnyType; | |||
| if (inputShape.hasTrait(PositionalTrait.class)) { | |||
| Shape inputForPositional = model.expectShape(inputShape.getAllMembers().values().stream().findFirst().get().getTarget()); | |||
There was a problem hiding this comment.
Why not getAllMembers().get(0) assuming it's a collection?
There was a problem hiding this comment.
getAllMembers() is a map but getAllMembers().values() is a collection. However, collection does not have get method.
| if (outputShape.hasTrait(UnitTypeTrait.class)) { | ||
| clientResponse = "var native_error"; | ||
| returnResponse = "dafny.TupleOf()"; | ||
| writer.addImportFromModule("github.com/dafny-lang/DafnyRuntimeGo", "dafny"); | ||
| inputType = maybeInputType; |
There was a problem hiding this comment.
Q: Why inputType is being assigned on a conditional on outputType?
Comment on lines
37
to
40
| // if (shape.isResourceShape()) { | ||
| // // TypesNamespace for resources are in ShapeName | ||
| // return shape.getId().getName(); | ||
| // } |
There was a problem hiding this comment.
Remove the commented code.
* fix: bump Rust version to 1.80
…atically (smithy-lang#554) As is the case for many suites of GitHub actions, it's a huge pain to manually maintain the list of required checks in the branch protection. This change leverages https://github.com/re-actors/alls-green to add a single capstone action that only passes if all dependent jobs pass (see repo README for details on why the naive approach doesn't work). Once this is approved I'll update the required checks before merging. Also adding Python tests to the list of triggers in the nightly build since I noticed it was missing.
This reverts commit ca4d375.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.