Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple comparison series to LineChart #1808

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

envex
Copy link
Collaborator

@envex envex commented Feb 13, 2025

What does this implement/fix?

As part of the ongoing tooltip work we want to allow charts to display multiple comparison lines.

These lines should be hidden until the matching series line is focused. If a chart only has a single comparison series, it show both the series and comparison series.

Does this close any currently open issues?

Resolves https://github.com/Shopify/core-issues/issues/84724

What do the changes look like?

multi-series.mov

Storybook link

Before merging

  • Check your changes on a variety of browsers and devices.

  • Update the Changelog's Unreleased section with your changes.

  • Update relevant documentation, tests, and Storybook.

  • Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package

@envex envex force-pushed the envex/remove-inactive-tooltip-rows branch from 12de87b to 1e4f8cc Compare February 13, 2025 16:09
@envex envex force-pushed the envex/multiple-comparisons branch 3 times, most recently from 3a3ff96 to 8a8bee5 Compare February 13, 2025 17:13
@envex envex changed the title Envex/multiple comparisons Add support for multiple comparison series to LineChart Feb 13, 2025
Copy link

github-actions bot commented Feb 13, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
polaris-viz-core-cjs 61.64 KB (+0.19% 🔺) 1.3 s (+0.19% 🔺) 1.3 s (+2.07% 🔺) 2.5 s
polaris-viz-cjs 230.77 KB (+0.24% 🔺) 4.7 s (+0.24% 🔺) 1.6 s (-28.59% 🔽) 6.2 s
polaris-viz-esm 186.66 KB (+0.21% 🔺) 3.8 s (+0.21% 🔺) 1.7 s (+20.99% 🔺) 5.5 s
polaris-viz-css 5.86 KB (0%) 118 ms (0%) 299 ms (-22.69% 🔽) 417 ms
polaris-viz-esnext 193.98 KB (+0.27% 🔺) 3.9 s (+0.27% 🔺) 1.5 s (+17.34% 🔺) 5.4 s

@envex envex force-pushed the envex/multiple-comparisons branch 2 times, most recently from 9fc393c to 024f14e Compare February 13, 2025 19:42
@envex envex force-pushed the envex/remove-inactive-tooltip-rows branch from 336e040 to 9b6e3a6 Compare February 13, 2025 21:15
@envex envex force-pushed the envex/multiple-comparisons branch from 024f14e to c845fcb Compare February 19, 2025 15:34
@envex envex changed the base branch from envex/remove-inactive-tooltip-rows to main February 19, 2025 15:39
@envex envex force-pushed the envex/multiple-comparisons branch 2 times, most recently from c1d0d57 to 8068e86 Compare February 19, 2025 18:08
@envex envex force-pushed the envex/multiple-comparisons branch from 8068e86 to 21635ba Compare February 19, 2025 18:16
@envex envex marked this pull request as ready for review February 19, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant