2024-04 upgrade cli-hydrogen@8 peer dependency conflict

[dvnrsn]

Am I crazy or is @shopify/cli-hydrogen indirectly wanting a higher version of react

└─┬ @shopify/cli-hydrogen@8.0.0
  └─┬ @shopify/cli-kit@3.58.0
    └── ink@4.4.1

Could not resolve dependency:
peer react@"^18.3.1" from react-reconciler@0.29.2
node_modules/ink/node_modules/react-reconciler
    react-reconciler@"^0.29.0" from ink@4.4.1
    node_modules/ink

Upgrading react + react-dom gives an issue of having more than one copy of react in the same app invalid hook call warning.

[dvnrsn]

Related #2055

[jamalsoueidan]

Mark it as an answer please.

[dvnrsn]

This is not the answer. It's simply related as indicated. Outstanding: fix the npm warnings which are inevitable if one uses @shopify/cli-hydrogen@8.0.0 and react@18.2 as they are incompatible.

[frandiox]

This was fixed in our latest release, 2024.4.2. I think if you update using the h2 upgrade command it should work. You might need to change your package-lock.json to ensure there's only 1 version of React installed as well if the h2 upgrade command alone doesn't work. For that, you could try npm remove react react-dom && npm install react react-dom, that should get you the latest React which is compatible with latest Hydrogen dependencies.