Merge pull request #313 from Shopify/enable-pprof-conditionally

Enable pprof conditionally

config.go

@@ -116,7 +116,7 @@ func (c *DatabaseConfig) MySQLConfig() (*mysql.Config, error) {
 			return nil, fmt.Errorf("failed to build TLS config: %v", err)
 		}
 
-		cfgName := fmt.Sprintf("%s@%s:%s", c.User, c.Host, c.Port)
+		cfgName := fmt.Sprintf("%s@%s:%d", c.User, c.Host, c.Port)
 
 		err = mysql.RegisterTLSConfig(cfgName, tlsConfig)
 		if err != nil {
@@ -764,6 +764,9 @@ type Config struct {
 	// The ghostferry target user should have SUPER permissions to actually write to the target DB,
 	// if ghostferry is ran with AllowSuperUserOnReadOnly = true and the target DB is set to read_only.
 	AllowSuperUserOnReadOnly bool
+
+	// If true, net/http/pprof will be enabled on port 6060.
+	EnablePProf bool
 }
 
 func (c *Config) ValidateConfig() error {

ferry.go

@@ -17,6 +17,8 @@ import (
 
 	sql "github.com/Shopify/ghostferry/sqlwrapper"
 
+	_ "net/http/pprof"
+
 	siddontangmysql "github.com/go-mysql-org/go-mysql/mysql"
 	"github.com/go-sql-driver/mysql"
 	siddontanglog "github.com/siddontang/go-log/log"
@@ -611,6 +613,15 @@ func (f *Ferry) Run() {
 	f.logger.Info("starting ferry run")
 	f.OverallState.Store(StateCopying)
 
+	if f.Config.EnablePProf {
+		go func() {
+			err := http.ListenAndServe("localhost:6060", nil)
+			if err != nil {
+				f.logger.WithError(err).Warn("pprof server finished")
+			}
+		}()
+	}
+
 	ctx, shutdown := context.WithCancel(context.Background())
 
 	handleError := func(name string, err error) {