Increase data volume for TestSelectiveCopyDataWithInsertLoadOnAllTena…

…nts, potential source of flakiness

Hypothesis: MixedActionDataWriter doesn't has a chance to start (goroutine), give it more time. Ideal solution would be to introduce some form of synchronization, but let's try this first. Partially reverts a speedup change from a288a28

sharding/test/trivial_integration_test.go

@@ -12,7 +12,7 @@ import (
 )
 
 func setupSingleTableDatabase(f *testhelpers.TestFerry, sourceDB, targetDB *sql.DB) {
-	testhelpers.SeedInitialData(sourceDB, "gftest", "table1", 100)
+	testhelpers.SeedInitialData(sourceDB, "gftest", "table1", 1000)
 	testhelpers.SeedInitialData(targetDB, "gftest", "table1", 0)
 
 	testhelpers.AddTenantID(sourceDB, "gftest", "table1", 3)
@@ -51,7 +51,7 @@ func TestSelectiveCopyDataWithoutAnyWritesToSource(t *testing.T) {
 	assert.Equal(t, 0, count)
 
 	rows := testcase.AssertQueriesHaveEqualResult("SELECT * FROM gftest.table1 WHERE tenant_id = 2")
-	assert.Equal(t, 33, len(rows))
+	assert.Equal(t, 333, len(rows))
 }
 
 func TestSelectiveCopyDataWithInsertLoadOnOtherTenants(t *testing.T) {
@@ -79,7 +79,7 @@ func TestSelectiveCopyDataWithInsertLoadOnOtherTenants(t *testing.T) {
 	assert.Equal(t, 0, count)
 
 	rows := testcase.AssertQueriesHaveEqualResult("SELECT * FROM gftest.table1 WHERE tenant_id = 2")
-	assert.Equal(t, 33, len(rows))
+	assert.Equal(t, 333, len(rows))
 }
 
 func TestSelectiveCopyDataWithInsertLoadOnAllTenants(t *testing.T) {
@@ -107,7 +107,7 @@ func TestSelectiveCopyDataWithInsertLoadOnAllTenants(t *testing.T) {
 	assert.Equal(t, 0, count)
 
 	rows := testcase.AssertQueriesHaveEqualResult("SELECT * FROM gftest.table1 WHERE tenant_id = 2")
-	assert.True(t, len(rows) > 33)
+	assert.True(t, len(rows) > 333)
 }
 
 type ChangeShardingKeyDataWriter struct {

testhelpers/data_writer.go

@@ -5,9 +5,8 @@ import (
 	"math/rand"
 	"sync"
 
-	sql "github.com/Shopify/ghostferry/sqlwrapper"
-
 	sq "github.com/Masterminds/squirrel"
+	sql "github.com/Shopify/ghostferry/sqlwrapper"
 )
 
 var dataletters = []rune("abcdefghijklmnopqrstuvwxyz")