Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update products.product.volume_pricing.price_at_each to products.product.volume_pricing.price_at_each_html #3718

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+73 −73
Open

Update products.product.volume_pricing.price_at_each to products.product.volume_pricing.price_at_each_html #3718

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4313f8
Update products.product.volume_pricing.price_at_each to products.prod…
veken1199 Feb 5, 2025
6d6e89c
Update 30 translation files
translation-platform[bot] Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion locales/en.default.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
"title": "Volume Pricing",
"note": "Volume pricing available",
"minimum": "{{ quantity }}+",
"price_at_each": "at {{ price }}/ea",
"price_at_each_html": "at {{ price }}/ea",
"price_range": "{{ minimum }} - {{ maximum }}"
},
"pickup_availability": {
Expand Down
12 changes: 6 additions & 6 deletions sections/featured-product.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,15 +251,15 @@
| money_with_currency
-%}
<span class="price-per-item--current">
{{- 'products.product.volume_pricing.price_at_each' | t: price: variant_price -}}
{{- 'products.product.volume_pricing.price_at_each_html' | t: price: variant_price -}}
</span>
{%- else -%}
{%- for price_break in volume_pricing_array -%}
{%- if current_qty_for_volume_pricing >= price_break.minimum_quantity -%}
{%- assign price_break_price = price_break.price | money_with_currency -%}
<span class="price-per-item--current">
{{-
'products.product.volume_pricing.price_at_each'
'products.product.volume_pricing.price_at_each_html'
| t: price: price_break_price
-}}
</span>
Expand Down Expand Up @@ -289,13 +289,13 @@
</dt>
<dd>
<span class="price-per-item--current">
{{- 'products.product.volume_pricing.price_at_each' | t: price: variant_price -}}
{{- 'products.product.volume_pricing.price_at_each_html' | t: price: variant_price -}}
</span>
</dd>
</dl>
{%- else -%}
<span class="price-per-item--current">
{{- 'products.product.volume_pricing.price_at_each' | t: price: variant_price -}}
{{- 'products.product.volume_pricing.price_at_each_html' | t: price: variant_price -}}
</span>
{%- endif -%}
</div>
Expand Down Expand Up @@ -339,7 +339,7 @@
{%- assign price = product.selected_or_first_available_variant.price
| money_with_currency
-%}
<span data-text="{{ 'products.product.volume_pricing.price_at_each' | t: price: variant_price }}">
<span data-text="{{ 'products.product.volume_pricing.price_at_each_html' | t: price: variant_price }}">
{{ 'sections.quick_order_list.each' | t: money: price -}}
</span>
</li>
Expand All @@ -351,7 +351,7 @@
<span aria-hidden="true">+</span></span
>
{%- assign price = price_break.price | money_with_currency -%}
<span data-text="{{ 'products.product.volume_pricing.price_at_each' | t: price: price_break_price }}">
<span data-text="{{ 'products.product.volume_pricing.price_at_each_html' | t: price: price_break_price }}">
{{ 'sections.quick_order_list.each' | t: money: price -}}
</span>
</li>
Expand Down Expand Up @@ -473,7 +473,7 @@
if product.selected_or_first_available_variant.featured_media
assign seo_media = product.selected_or_first_available_variant.featured_media
else
assign seo_media = product.featured_media

Check warning on line 476 in sections/featured-product.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/featured-product.liquid#L476 

[UnusedAssign] The variable 'seo_media' is assigned but not used
endif
-%}

Expand Down
12 changes: 6 additions & 6 deletions sections/main-product.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,15 +318,15 @@
| money_with_currency
-%}
<span class="price-per-item--current">
{{- 'products.product.volume_pricing.price_at_each' | t: price: variant_price -}}
{{- 'products.product.volume_pricing.price_at_each_html' | t: price: variant_price -}}
</span>
{%- else -%}
{%- for price_break in volume_pricing_array -%}
{%- if current_qty_for_volume_pricing >= price_break.minimum_quantity -%}
{%- assign price_break_price = price_break.price | money_with_currency -%}
<span class="price-per-item--current">
{{-
'products.product.volume_pricing.price_at_each'
'products.product.volume_pricing.price_at_each_html'
| t: price: price_break_price
-}}
</span>
Expand Down Expand Up @@ -356,13 +356,13 @@
</dt>
<dd>
<span class="price-per-item--current">
{{- 'products.product.volume_pricing.price_at_each' | t: price: variant_price -}}
{{- 'products.product.volume_pricing.price_at_each_html' | t: price: variant_price -}}
</span>
</dd>
</dl>
{%- else -%}
<span class="price-per-item--current">
{{- 'products.product.volume_pricing.price_at_each' | t: price: variant_price -}}
{{- 'products.product.volume_pricing.price_at_each_html' | t: price: variant_price -}}
</span>
{%- endif -%}
</div>
Expand Down Expand Up @@ -406,7 +406,7 @@
{%- assign price = product.selected_or_first_available_variant.price
| money_with_currency
-%}
<span data-text="{{ 'products.product.volume_pricing.price_at_each' | t: price: variant_price }}">
<span data-text="{{ 'products.product.volume_pricing.price_at_each_html' | t: price: variant_price }}">
{{- 'sections.quick_order_list.each' | t: money: price -}}
</span>
</li>
Expand All @@ -417,7 +417,7 @@
{{- price_break.minimum_quantity -}}
<span aria-hidden="true">+</span></span
>
<span data-text="{{ 'products.product.volume_pricing.price_at_each' | t: price: price_break_price }}">
<span data-text="{{ 'products.product.volume_pricing.price_at_each_html' | t: price: price_break_price }}">
{{- 'sections.quick_order_list.each' | t: money: price_break_price -}}
</span>
</li>
Expand Down Expand Up @@ -570,7 +570,7 @@
<ul class="list-unstyled" role="list">
{%- for product in recommendations.products
limit: block.settings.products_per_page
offset: continue

Check warning on line 573 in sections/main-product.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/main-product.liquid#L573 

[UndefinedObject] Unknown object 'continue' used.
-%}
<li>
{%- if block.settings.enable_quick_add -%}
Expand Down Expand Up @@ -714,7 +714,7 @@
if product.selected_or_first_available_variant.featured_media
assign seo_media = product.selected_or_first_available_variant.featured_media
else
assign seo_media = product.featured_media

Check warning on line 717 in sections/main-product.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/main-product.liquid#L717 

[UnusedAssign] The variable 'seo_media' is assigned but not used
endif
-%}

Expand Down
Loading