Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update products.product.volume_pricing.price_at_each to products.product.volume_pricing.price_at_each_html #3718

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

veken1199
Copy link

PR Summary:

We are updating products.product.volume_pricing.price_at_each to products.product.volume_pricing.price_at_each_html

Why are these changes introduced?

We would like to make sure that currency html settings that respected and not escaped during the translation.

What approach did you take?

we added _html prefix to products.product.volume_pricing.price_at_each. We also kept products.product.volume_pricing.price_at_each for backward compatibility. I will check the team to see if that is needed cc @tyleralsbury

Checklist

@veken1199 veken1199 force-pushed the update-price-translation-key branch from bca6e5b to 150ad8d Compare February 5, 2025 16:37
Copy link
Contributor

@ludoboludo ludoboludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to request translations now so it can be updated across the board.

@veken1199 veken1199 force-pushed the update-price-translation-key branch from a934e98 to d4313f8 Compare February 18, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants