-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Country/region selector is still shown in mobile drawer even when it's disabled #2919
Comments
The cause is this PR #2725 (file changes) |
Hi there. This was an intentional decision. Themes now have 3 sections where the language and currency picker can be enabled/disabled
The mobile drawer pop-out component lives within the Header section. There is no mechanism in liquid themes to share settings between sections, and we made the decision to show the language and currency picker in the mobile drawer by default IF the shop itself had multiple languages and/or multiple currencies configured. To help me understand the merchant's frustration here, can you please describe WHY a merchant might want to hide these settings if their shop is setup to sell in multiple languages/currencies? |
@kimberlyoleiro Thanks for your reply. Our store is international, but for now is setup to sell in English and use USD. So there is no need to setup the languages/currencies. Otherwise, we will see all countries use English/USD in the selector. |
Here's another use case. The merchant is in the UAE, and only sells in USD. They can not use Shopify Payments to have sales in Local currencies. That means, in the mobile menu all countries are showing up, but with USD for the currency. They are also using an app to show the approximate local currency amount on the website. Until the checkout converts back to USD. So now, they have 2 lists of countries. One saying USD, and one saying (local currency), meanwhile the display on the site is showing local currency. This is causing confusion. My suggestion is if the options are hidden in the header section, they should be hidden in the header section on all devices. Not just desktop view. Since the Menu is in the header, it is aware of the setting there. Screenshots to help illustrateInstalled app with approximate currency conversion Theme provided list of countries, all selling in USD Price displaying in CAD due to the app. Conflicting with the theme provided dropdown. |
Hi Team! I hope all is well! Adding this merchant as a sample who also had the same issue: |
Hi team, adding this store, same instance. |
Hi team, adding this case of the issue: |
Hi team 👋 Adding another instance here: |
The Country/region selector is still shown in mobile drawer even when it's disabled.
The Dawn Version I tested is:
11.0.0
Here is the screenshots:
The text was updated successfully, but these errors were encountered: