Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country/region selector is still shown in mobile drawer even when it's disabled #2919

Open
caizelin opened this issue Jul 27, 2023 · 8 comments · May be fixed by #3118
Open

Country/region selector is still shown in mobile drawer even when it's disabled #2919

caizelin opened this issue Jul 27, 2023 · 8 comments · May be fixed by #3118
Labels
Category: Enhancement New feature or request

Comments

@caizelin
Copy link

The Country/region selector is still shown in mobile drawer even when it's disabled.
The Dawn Version I tested is: 11.0.0
Here is the screenshots:

Screen Shot 2023-07-27 at 6 08 12 PM
@kybun-swiss
Copy link

The cause is this PR #2725 (file changes)

@ludoboludo ludoboludo added the Category: Enhancement New feature or request label Aug 10, 2023
@kimberlyoleiro
Copy link

Hi there. This was an intentional decision. Themes now have 3 sections where the language and currency picker can be enabled/disabled

  1. Footer << original
  2. Header << new
  3. Announcement bar << newest

The mobile drawer pop-out component lives within the Header section.

There is no mechanism in liquid themes to share settings between sections, and we made the decision to show the language and currency picker in the mobile drawer by default IF the shop itself had multiple languages and/or multiple currencies configured.

To help me understand the merchant's frustration here, can you please describe WHY a merchant might want to hide these settings if their shop is setup to sell in multiple languages/currencies?

@caizelin
Copy link
Author

caizelin commented Aug 11, 2023

@kimberlyoleiro Thanks for your reply. Our store is international, but for now is setup to sell in English and use USD. So there is no need to setup the languages/currencies. Otherwise, we will see all countries use English/USD in the selector.

@shawnr42
Copy link

Here's another use case.

The merchant is in the UAE, and only sells in USD. They can not use Shopify Payments to have sales in Local currencies. That means, in the mobile menu all countries are showing up, but with USD for the currency.

They are also using an app to show the approximate local currency amount on the website. Until the checkout converts back to USD.

So now, they have 2 lists of countries. One saying USD, and one saying (local currency), meanwhile the display on the site is showing local currency. This is causing confusion.

My suggestion is if the options are hidden in the header section, they should be hidden in the header section on all devices. Not just desktop view. Since the Menu is in the header, it is aware of the setting there.

Screenshots to help illustrate

Installed app with approximate currency conversion

image


Theme provided list of countries, all selling in USD

image


Price displaying in CAD due to the app. Conflicting with the theme provided dropdown.

image

@Roi-Arthur Roi-Arthur linked a pull request Nov 20, 2023 that will close this issue
13 tasks
@delrosario3074211
Copy link

Hi Team! I hope all is well!

Adding this merchant as a sample who also had the same issue:

Internal Dashboard
Zendesk Ticket

@Candolita3231432
Copy link

Hi team, adding this store, same instance.

Internal
Zendesk ticket

@PaulAShortt
Copy link

Hi team, adding this case of the issue:

Store Internal
Zendesk Ticket

@Pineda3006988
Copy link

Hi team 👋 Adding another instance here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants