Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BFCL] Update tool construction for Palmyra models #897

Merged
merged 1 commit into from
Feb 2, 2025
Merged

[BFCL] Update tool construction for Palmyra models #897

merged 1 commit into from
Feb 2, 2025

Conversation

samjulien
Copy link
Contributor

@samjulien samjulien commented Jan 30, 2025 •
edited
Loading

I've updated utils.py in BFCL to reflect some needed changes to how tools are constructed when using Writer's models such as Palmyra X 004.

cc @HuanzhiMao

@HuanzhiMao HuanzhiMao added the BFCL-General General BFCL Issue label Feb 2, 2025
HuanzhiMao
HuanzhiMao approved these changes Feb 2, 2025
View reviewed changes
Copy link
Collaborator

@HuanzhiMao HuanzhiMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM

@HuanzhiMao HuanzhiMao merged commit cfca2f4 into ShishirPatil:main Feb 2, 2025
@HuanzhiMao HuanzhiMao mentioned this pull request Feb 4, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuanzhiMao HuanzhiMao HuanzhiMao approved these changes

Assignees
No one assigned
Labels
BFCL-General General BFCL Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samjulien @HuanzhiMao