From ce64bc0b260792b5bb14ba77678bce24da5e2fe7 Mon Sep 17 00:00:00 2001
From: Shindou Mihou <git@mihou.pw>
Date: Fri, 6 Oct 2023 11:39:14 +0800
Subject: [PATCH] feat: revert `remove` on `commandManager`

This change included the potential to break the indexing system of Nexus which currently doesn't support removing of indexes. As this would inherently introduce a breaking change among bots that uses persistent indexes, it's decided to remove it instead
---
 .../managers/core/NexusCommandManagerCore.kt   | 18 ------------------
 .../managers/facade/NexusCommandManager.kt     |  6 ------
 2 files changed, 24 deletions(-)

diff --git a/src/main/java/pw/mihou/nexus/core/managers/core/NexusCommandManagerCore.kt b/src/main/java/pw/mihou/nexus/core/managers/core/NexusCommandManagerCore.kt
index 63bca45a..774a61eb 100755
--- a/src/main/java/pw/mihou/nexus/core/managers/core/NexusCommandManagerCore.kt
+++ b/src/main/java/pw/mihou/nexus/core/managers/core/NexusCommandManagerCore.kt
@@ -49,16 +49,6 @@ class NexusCommandManagerCore internal constructor() : NexusCommandManager  {
         return this
     }
 
-    override fun remove(command: NexusCommand): NexusCommandManager {
-        removeContextMenu(command.uuid)
-        return this
-    }
-
-    override fun remove(contextMenu: NexusContextMenu): NexusCommandManager {
-        removeContextMenu(contextMenu.uuid)
-        return this
-    }
-
     override operator fun get(applicationId: Long): NexusCommand? = indexStore[applicationId]?.takeCommand()
     override operator fun get(uuid: String): NexusCommand? = commandsDelegate[uuid]
     override operator fun get(name: String, server: Long?): NexusCommand? {
@@ -95,14 +85,6 @@ class NexusCommandManagerCore internal constructor() : NexusCommandManager  {
         }
     }
 
-    override fun removeContextMenu(uuid: String) {
-        contextMenusDelegate.remove(uuid)
-    }
-
-    override fun removeSlashCommand(uuid: String) {
-        commandsDelegate.remove(uuid)
-    }
-
     override fun export(): List<NexusMetaIndex> {
         return indexStore.all()
     }
diff --git a/src/main/java/pw/mihou/nexus/core/managers/facade/NexusCommandManager.kt b/src/main/java/pw/mihou/nexus/core/managers/facade/NexusCommandManager.kt
index 81ab1239..9bd17d88 100755
--- a/src/main/java/pw/mihou/nexus/core/managers/facade/NexusCommandManager.kt
+++ b/src/main/java/pw/mihou/nexus/core/managers/facade/NexusCommandManager.kt
@@ -140,9 +140,6 @@ interface NexusCommandManager {
     fun add(command: NexusCommand): NexusCommandManager
     fun add(contextMenu: NexusContextMenu): NexusCommandManager
 
-    fun remove(command: NexusCommand): NexusCommandManager
-    fun remove(contextMenu: NexusContextMenu): NexusCommandManager
-
     operator fun get(applicationId: Long): NexusCommand?
     operator fun get(uuid: String): NexusCommand?
     operator fun get(name: String, server: Long? = null): NexusCommand?
@@ -151,9 +148,6 @@ interface NexusCommandManager {
     fun getContextMenu(uuid: String): NexusContextMenu?
     fun getContextMenu(name: String, kind: ContextMenuKinds, server: Long? = null): NexusContextMenu?
 
-    fun removeContextMenu(uuid: String)
-    fun removeSlashCommand(uuid: String)
-
     /**
      * Exports the indexes that was created which can then be used to create a database copy of the given indexes.
      * <br></br><br></br>