small perf improvements in ProtoToGraphNodeMappings and ZipArchive #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltek
commented
Jan 10, 2025
| private var protoNodeIdToGNode = Map.empty[Long, DNode] | ||
| private var typeFullNameToGNode = Map.empty[String, DNode] | ||
|
|
||
| def addAll(other: ProtoToGraphNodeMappings): Unit = { |
There was a problem hiding this comment.
removing this since it appears unused, not because there's any problem implementing it with the mutable maps
mpollmeier
approved these changes
Jan 10, 2025
|
PR build will greenify with #1799 |
the immmutable maps have some unneccessary overhead
mpollmeier
force-pushed
the
mkraus/small-perf-fixes
branch
from
1967e6e to
cba2036
Compare
bbrehm
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArraySeq