Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuffle & Add To Playlist: reshuffle "tracks that have not yet played" except "play next" stack #46

Open
Sheraff opened this issue Jan 19, 2023 · 1 comment
Labels
invalid This doesn't seem right

Comments

@Sheraff
Copy link
Owner

Sheraff commented Jan 19, 2023

Currently, when adding a track to the currently playing playlist with shuffle on, we re-shuffle the entire playlist (with current track set as the first).

A better / more "expected" behavior would be

  • leave already played tracks as is in the order (up to and including cache.current shouldn't change)
  • leave "string of uninterrupted tracks that are in the play next stack" as is in the order
  • shuffle the rest
@Sheraff
Copy link
Owner Author

Sheraff commented Apr 17, 2023

Not reproducing, needs more explanation.

Tried:

  • start album, play
  • activate shuffle
  • forward twice, order of plays was 1, 8, 5
  • "add next to playlist"
  • backward twice, forward thrice, order was still 1 8 5 (and new one)

@Sheraff Sheraff added the invalid This doesn't seem right label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant