Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotify & audioDB results should be checked #12

Open
3 tasks
Sheraff opened this issue Oct 29, 2022 · 2 comments
Open
3 tasks

Spotify & audioDB results should be checked #12

Sheraff opened this issue Oct 29, 2022 · 2 comments
Assignees
Labels
robustness Not a bug, but not a good sign either

Comments

@Sheraff
Copy link
Owner

Sheraff commented Oct 29, 2022

Lastfm & acoustid results are validated by a string distance algorithm similarStrings to increase the certainty that they match the requested track.

  • The same should be done for spotify track searches.
  • The same should be done for audiodb searches that are not based on MBID

Where a better "result selection" is needed, there are // TODO: use string distance comments. Though, the proper way of selecting a result might not simply be string distance but something more along the lines of what is done w/ acoustid results.

Potentially:

  • Select lastfm result w/ better algorithm (similar to what is done w/ acoustid results), marked with // TODO: can we do better
@Sheraff Sheraff changed the title Spotify track results should be checked Spotify & audioDB results should be checked Nov 1, 2022
@Sheraff Sheraff self-assigned this Nov 1, 2022
@Sheraff Sheraff added the robustness Not a bug, but not a good sign either label Apr 23, 2023
@Sheraff
Copy link
Owner Author

Sheraff commented Apr 29, 2023

23bfe7a

=> uses string distance to select result for spotify & audiodb (does not filter out, only used to select the best one)

@Sheraff
Copy link
Owner Author

Sheraff commented Apr 29, 2023

d964771

=> lastfm name correction is checked by a string distance on track creation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
robustness Not a bug, but not a good sign either
Projects
None yet
Development

No branches or pull requests

1 participant