Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vite migration #874

Merged
merged 26 commits into from
Mar 26, 2024
Merged

vite migration #874

merged 26 commits into from
Mar 26, 2024

Conversation

rphlmr
Copy link
Contributor

@rphlmr rphlmr commented Mar 22, 2024 •
edited
Loading

#850

Todo:

  • Migrate to ESM
  • Add new dev server
  • Remove barrels indexes
  • Migrate css imports
  • Update Dockerfile

@rphlmr rphlmr self-assigned this Mar 22, 2024
@DonKoko DonKoko changed the base branch from main to 850-feature-request-migrate-to-vite March 22, 2024 14:08
@rphlmr rphlmr marked this pull request as ready for review March 25, 2024 16:00
@rphlmr
Copy link
Contributor Author

rphlmr commented Mar 25, 2024

👋 @anatolinicolae I'm pinging you for the Dockerfiles updates ;)

rphlmr
rphlmr commented Mar 25, 2024
View reviewed changes
server/index.ts Outdated Show resolved Hide resolved
DonKoko
DonKoko requested changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 1 small change required

server/index.ts Outdated Show resolved Hide resolved
@DonKoko DonKoko merged commit 989e56e into Shelf-nu:850-feature-request-migrate-to-vite Mar 26, 2024
4 checks passed
@DonKoko
Copy link
Contributor

DonKoko commented Mar 26, 2024

This PR is merged to the local branch inside shelf repo. Further progress can be tracked here: #882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonKoko DonKoko DonKoko approved these changes

Assignees

@rphlmr rphlmr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rphlmr @DonKoko