[Feature request]: Create a flow to link an 'unclaimed tag' to an existing asset

[carlosvirreira]

Contact Details

No response

Is your feature request related to a problem? Please describe?

As a user, if I am trying to get labels from the Shelf team - I mostly have to either:

1. Stop what I am doing and wait for my labels
2. Create all my assets and then order labels

Describe the solution you'd like

Ideally I can order shelf asset tags and when scanning I can pick either to link them to an existing asset or create a brand new asset.

Describe alternatives you've considered

No response

Additional context

No response

[DonKoko]

@jurrejansen @carlosvirreira do we have a design for this? I thought we did but I don't remember where to find it.

[jurrejansen]

Hi @DonKoko there are very old designs here https://www.figma.com/file/2XkiKJ4II7Mux6JJL9hYTm/Shelf-App-%7C-Production-Ready?type=design&node-id=6267-340162&mode=design

But I think they need to be revisited. Are you planning to work on this in the near future?

Also I think this concept needs to be added to the flowchart of scanning logic.

https://www.figma.com/file/oBSRWYlWtjlLwu39LtpMHS/Shelf-%7C-FigJam?type=whiteboard&node-id=0%3A1&t=NS9UefEGJgxeqlK4-1

[jurrejansen]

Hi @DonKoko here's the scenario, let me know if anything is unclear.

https://www.figma.com/file/ykvc0MhPeNLsrJ4tJsKosQ/Shelf-%7C-UX-Scenarios?type=design&node-id=4199-41708&mode=design

[carlosvirreira]

Very clear to me - great enhancement.

[DonKoko]

@carlosvirreira @jurrejansen this is deployed on testapp and ready to be tested.
1 small note. We have a different bug related to vite that breaks the asset page if there is a location of the last scan. Please dont give your browser location permissions when testing this feature so it doesn't break the asset.

Some testing recommendations:

1. To to admin panel
2. Find your user and click on any org
3. Generate some orphan codes and click the code id
4. That will trigger the process

[jurrejansen]

FEEDBACK

• The built in scanner does not work for orphaned codes

RPReplay_Final1711536889.MP4

• I think we should remove section with the Shelf logo as it is taking up some much needed screen real estate. I know this is an easy way to get back to the main part of the app but still. They can choose 'Close' and back out from there

• Can we decrease font size of the heading to match design (18px / 1.25rem)

• Can we change copy heading into: Link with existing asset

• Can we change copy of sub text into: Choose an asset to link with this QR tag.

• Can we add the border lines separating the different sections of the modal / page

• Can we have to border lines taking up the full width of the screen

• Any way we can avoid the browser UI covering the fixed footer that contains the 'Close' button. For example, this doesn't happen with the Manage assets modal for bookings on mobile.

QUESTIONS

@DonKoko @carlosvirreira

• Do we really need the 'Status' filter when linking a code to existing asset? Personally think the extra screen real estate by removing it preferable
• Do we need need to show the status of an asset here? There's not really a downside to it i guess

[carlosvirreira]

Hi @jurrejansen good report:

Do we really need the 'Status' filter when linking a code to existing asset? Personally think the extra screen real estate by removing it preferable

I'd say no. However, I do believe that the approach here was to ship a v1 fast. I would rather have something that is 90% good out there and solves the problem than spending a ton of time over-polishing.

The rest of the content/language changes are highly appreciated.

[DonKoko]

One more point to add:

• the quick actions after scanning a qr seem to be broken on dev branch. Happens both with in-app scanner and camera app

[DonKoko]

the quick actions after scanning a qr seem to be broken on dev branch. Happens both with in-app scanner and camera app

This is caused by the vite update. I am now deploying to testapp without vite to double confirm it. Also mentioned in #882

EDIT: Confirmed thats the reason

[DonKoko]

The built in scanner does not work for orphaned codes

@jurrejansen Man I spent like 5h testing this and it was so stupid. Its just because you are trying to scan it via preview on the mac. And the way we made the app "print" the codes is without white space around them. Based on the QR spec this white space is kinda required. We just did it like this because of our process of placing them on sheets and printing them.

I made 1 code with whitespace around it and it instantly worked.

So I think the only thing we have to know about this is to actually inform our users who ask us to send them orphaned codes that the codes need at least like 5-10px white space on each side so the scanner can recognize them.

Another option is that I just add some margin already to the QR code and you will need to adjust your template.

[DonKoko]

@jurrejansen all the changes are deployed to testapp. Please test again and lmk if we are ready to go live.

[jurrejansen]

@DonKoko Some minor stuff

• Change copy from "Link with existingasset" -> "Link with existing asset"
• Missed it last time, would it be a hassle to add the Location filter in this component? This also applies to the Manage assets modal for bookings

RPReplay_Final1712044228.MP4

• Top border of footer section isn't full width
• Header section isn't separated by a border

Any way we can avoid the browser UI covering the fixed footer that contains the 'Close' button. For example, this doesn't happen with the Manage assets modal for bookings on mobile.

For me this still happens, the footer with Close button is hidden behind browser UI. Not sure how many users will get confused by this and there's always the Previous button from the browser they could use. However, for Manage assets modal this doesn't happen.

RPReplay_Final1712044826.MP4

• Let's always call it 'asset' instead of 'item' for consistency

---

Yeah I guess it's best to bake in the whitespace then. Something like the screenshot down below, not too much. I tested again and now I was able to scan an orphaned code via the mac preview for some reason.

RPReplay_Final1712045840.MP4

[DonKoko]

@jurrejansen deployed to testapp.

Missed it last time, would it be a hassle to add the Location filter in this component? This also applies to the Manage assets modal for bookings

Nowadays its easy so I added it no problem.

[jurrejansen]

@DonKoko nice, all seems good to me. Closing