Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ID shift from removing Coke Oven Bricks #146

Open
Exaxxion opened this issue May 7, 2021 · 0 comments
Open

ID shift from removing Coke Oven Bricks #146

Exaxxion opened this issue May 7, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@Exaxxion
Copy link
Collaborator

Exaxxion commented May 7, 2021

Removing the Coke Oven Bricks in #122 caused an ID shift in the gearbox casing ID (used in the Assembly Line). This made it into the 2.18.0 release and fixing it is a priority so we can push a hotfix.

In the short term, reverting that commit may suffice. In the longer term, as with the ID shifts in GTCE, we need to investigate a mapping scheme with deterministic ordering so shifts don't happen if we add or remove things in the future.
@Exaxxion Exaxxion added the bug Something isn't working label May 7, 2021
@ALongStringOfNumbers ALongStringOfNumbers mentioned this issue May 7, 2021
Merged
Exaxxion pushed a commit that referenced this issue May 7, 2021
@ALongStringOfNumbers
Hotfix for Assembly Line Casing ID Shift (#147)
5393918 
* Revert "Remove Coke Oven Bricks (#122)"
* Hide the Coke Oven block from JEI until we can actually remove it.
* See #146 for more information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Exaxxion