Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: investigate better ways to implement recipe replacements #144

Open
Exaxxion opened this issue May 6, 2021 · 0 comments · May be fixed by #141
Open

TODO: investigate better ways to implement recipe replacements #144

Exaxxion opened this issue May 6, 2021 · 0 comments · May be fixed by #141
Labels
cleanup Code cleanups & refactoring

Comments

@Exaxxion
Copy link
Collaborator

Exaxxion commented May 6, 2021

Looping through the material registry and doing a lot of type checks and casting to accomplish the recipe replacements is clunky and potentially error prone (e.g. filtering by IngotMaterial for cables misses the edge case of Superconductor which is a MarkerMaterial).

Let's investigate alternatives that could improve accuracy and efficiency. We were tipped off about RecipeHandlers, so let's look into that.
@Exaxxion Exaxxion added the cleanup Code cleanups & refactoring label May 6, 2021
@ALongStringOfNumbers ALongStringOfNumbers linked a pull request Jun 2, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Code cleanups & refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup of Recipes and moving to RecipeHandlers Shadows-of-Fire/Shadows-of-Greg
1 participant
@Exaxxion