Skip to content

Commit

Permalink
fix: try ad-hoc but better?
Browse files Browse the repository at this point in the history
  • Loading branch information
Nerixyz committed Jan 13, 2024
1 parent f3816f9 commit 2e1c40e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
6 changes: 0 additions & 6 deletions .CI/CreateDMG.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ if [ -n "$MACOS_CODESIGN_CERTIFICATE" ]; then
echo "Codesigning force deep inside the app"
codesign -s "$MACOS_CODESIGN_CERTIFICATE" --deep --force chatterino.app
echo "Done!"
else
codesign --remove-signature chatterino.app
codesign -s - chatterino.app
fi

echo "Running dmgbuild.."
Expand All @@ -38,7 +35,4 @@ if [ -n "$MACOS_CODESIGN_CERTIFICATE" ]; then
echo "Codesigning the dmg"
codesign -s "$MACOS_CODESIGN_CERTIFICATE" --deep --force "$OUTPUT_DMG_PATH"
echo "Done!"
else
codesign --remove-signature "$OUTPUT_DMG_PATH"
codesign -s - "$OUTPUT_DMG_PATH"
fi
2 changes: 1 addition & 1 deletion .CI/MacDeploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ mkdir -p chatterino.app/Contents/PlugIns/imageformats
cp kimg/libKF5Archive.5.dylib chatterino.app/Contents/Frameworks/
cp kimg/kimg_avif.so chatterino.app/Contents/PlugIns/imageformats/

macdeployqt chatterino.app "${_macdeployqt_args[@]}" -verbose=3
macdeployqt chatterino.app "${_macdeployqt_args[@]}" -verbose=1

if [ -n "$MACOS_CODESIGN_CERTIFICATE" ]; then
# Validate that chatterino.app was codesigned correctly
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,8 @@ jobs:
pwd
ls -la build || true
cd build
export MACOS_CODESIGN_CERTIFICATE="-"
echo "-> $MACOS_CODESIGN_CERTIFICATE"
brew reinstall openssl
echo "Downloading kimageformats plugins"
Expand Down

0 comments on commit 2e1c40e

Please sign in to comment.