Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description
Fix: #244
This should fix all the bugs described in #244:
_set_implicit_default
forsequence_tensor_parallel
since it's an override and not an implicit default. (fix the bug reported for sequence data parallel, though it doesn't technically relates to the feature)Also address other minor issues and failing tests, and a tentative fix for #249.
🔍 Type of change
Select all that apply: