Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch back to official spacetime package #152

Open
Serraniel opened this issue Dec 29, 2020 · 4 comments
Open

Switch back to official spacetime package #152

Serraniel opened this issue Dec 29, 2020 · 4 comments
Assignees
@Serraniel
Labels
Priority: Medium Average priority issue. State: Blocked Issue is blocked by another issue. Type: Maintenance The issue describes some kind of maintenance which has to be done for the project or repository.

Comments

@Serraniel
Copy link
Owner

During the typescript migration (#48 ) spacetime was replaced with a customized version due to incomplete type definitions. I created a pull request with a fix in the spacetime repository: spencermountain/spacetime#256

As soon as this is merged and published we should switch back to the original spacetime package via npm.
@Serraniel
Copy link
Owner Author

See a6b7c3b.

@Serraniel Serraniel added Priority: Medium Average priority issue. State: New New items which hasn´t been sighted yet. Type: Maintenance The issue describes some kind of maintenance which has to be done for the project or repository. labels Dec 29, 2020
@Serraniel
Copy link
Owner Author

I´ll set this as blocked, until the update is available.

@Serraniel Serraniel added State: Blocked Issue is blocked by another issue. and removed State: New New items which hasn´t been sighted yet. labels Dec 29, 2020
@Serraniel Serraniel added State: New New items which hasn´t been sighted yet. and removed State: Blocked Issue is blocked by another issue. labels Feb 4, 2021
@Serraniel
Copy link
Owner Author

An update for spacetime has been released today, so it can be changed to original version again now.

@Serraniel Serraniel self-assigned this Feb 4, 2021
@Serraniel Serraniel added State: In progress Issue in development. and removed State: New New items which hasn´t been sighted yet. labels Feb 4, 2021
Serraniel added a commit that referenced this issue Feb 4, 2021
@Serraniel
#152 Updated spacetime
720aca5 
There now is a new bug I may will report on the weekend if I find my time.
@Serraniel
Copy link
Owner Author

There has been some more changes in the typescript definitions on spacetime in 581f6a1e53718e12454bd7e94498785f5fb983f0 which break the new update.

I will try to report or fix the issue on the weekend to the project.

@Serraniel Serraniel added State: Blocked Issue is blocked by another issue. and removed State: In progress Issue in development. labels Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Serraniel Serraniel

Labels
Priority: Medium Average priority issue. State: Blocked Issue is blocked by another issue. Type: Maintenance The issue describes some kind of maintenance which has to be done for the project or repository.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Serraniel