Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzuraCast fixes #255

Merged
merged 5 commits into from
Jan 19, 2025
Merged

AzuraCast fixes #255

merged 5 commits into from
Jan 19, 2025

Conversation

Sella-GH
Copy link
Owner

No description provided.

@Sella-GH Sella-GH added bug Something isn't working area-docker Docker related stuff area-bot Stuff which is related to the bot labels Jan 19, 2025
@Sella-GH Sella-GH added this to the 2.3.0 milestone Jan 19, 2025
@Sella-GH Sella-GH self-assigned this Jan 19, 2025
@Copilot Copilot bot review requested due to automatic review settings January 19, 2025 19:42

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • dev.Dockerfile: Language not supported
Comments suppressed due to low confidence (3)

src/AzzyBot.Bot/Services/Modules/AzuraCastPingService.cs:22

  • [nitpick] The error message string could be clearer. Consider rephrasing to 'The certificate for AzuraCast instance URI is self-signed and therefore not valid! Please install a valid HTTPS certificate for your AzuraCast instance so AzzyBot can safely connect to it.'
private const string ValidCertNeeded = "The certificate for AzuraCast instance **URI** is self-signed and therefore not valid!\nYou need a valid HTTPS certificate for your AzuraCast instance so AzzyBot can safely connect to it.";

src/AzzyBot.Bot/Commands/ConfigCommands.cs:113

  • The error message 'Apparently you have an AzuraCast instance configured, but it's not online.' was removed. This might lead to confusion if the instance is not online, and the user doesn't get any feedback.
await context.DeleteResponseAsync();

src/AzzyBot.Bot/Commands/ConfigCommands.cs:591

  • [nitpick] The variable name 'ac' is ambiguous. It should be renamed to 'azuraCastInstance'.
AzuraCastEntity ac = guild.AzuraCast;
@Sella-GH Sella-GH enabled auto-merge (squash) January 19, 2025 19:43
@Sella-GH Sella-GH disabled auto-merge January 19, 2025 19:46
@Sella-GH Sella-GH merged commit 58ab9fc into main Jan 19, 2025
3 checks passed
@Sella-GH Sella-GH deleted the dev/AzuraCastFixes branch January 19, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-bot Stuff which is related to the bot area-docker Docker related stuff bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant