-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
add details tag with full example to code snippets #2276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I like the idea of users being able to get more/the full example w/o having to navigate to github |
At this point we need to make the bigger decision of whether we're even going to stick with Hugo or move to Docusaurus. :) |
I don't see the point of moving to a new tool if we don't resolve the structure we want to have in docs first. |
User description
Demo to show an option for how we might improve things. It overflows the tab, so this isn't what we actually want, but looking for feedback on the concept.
PR Type
Enhancement
Description
Added a collapsible
details
tag to display full code examples.Improved user experience by showing snippets with an option for full content.
Enhanced conditional rendering for fragments in code blocks.
Changes walkthrough 📝
gh-codeblock.html
Added collapsible full example display for code snippets
website_and_docs/layouts/shortcodes/gh-codeblock.html
details
tag to display full examples.