Skip to content

Commit

Permalink
chore: Fix go version during ci lint (argoproj#401)
Browse files Browse the repository at this point in the history
* chore: Fix go version during ci lint

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Fix go version minor version only

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
  • Loading branch information
leoluz authored Apr 11, 2022
1 parent 73bcea9 commit a586397
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ on:
pull_request:
branches:
- 'master'
env:
# Golang version to use across CI steps
GOLANG_VERSION: '1.17'
jobs:
test:
runs-on: ubuntu-latest
Expand All @@ -21,13 +24,14 @@ jobs:
${{ runner.os }}-go-
- uses: actions/setup-go@v2.1.4
with:
go-version: '1.17.6'
go-version: ${{ env.GOLANG_VERSION }}
- run: make test
- name: Run golangci-lint
uses: golangci/golangci-lint-action@v2
with:
version: v1.38.0
args: --timeout 5m
skip-go-installation: true
- uses: codecov/codecov-action@v1.5.0
with:
token: ${{ secrets.CODECOV_TOKEN }} #required
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.14.3 as builder
FROM golang:1.17 as builder

WORKDIR /src

Expand All @@ -13,4 +13,4 @@ RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags="-w -s" -o /dist/git


FROM alpine/git:v2.24.3
COPY --from=builder /dist/gitops /usr/local/bin/gitops
COPY --from=builder /dist/gitops /usr/local/bin/gitops

0 comments on commit a586397

Please sign in to comment.