Variable window length #46
krisvanneste
started this conversation in
Ideas
Replies: 2 comments 1 reply
-
@claudiodsf Do you have time to look at this? |
Beta Was this translation helpful? Give feedback.
0 replies
-
Hi Kris, thanks for the reminder and for this proposition! Let me try to make some quick comments right now 😉 :
Let me know if that is enough to start drafting an implementation and if you can do it 😉 . Claudio |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi Claudio,
I have started looking how a variable window length could be implemented in sourcespec.
One idea is simply to define the window length variability as a fraction of the travel time of the considered wave.
This could be implemented easily as follows:
variable_win_length_factor
(or maybevariable_win_length_tt_fraction
to be more explicit) with default value 0.If origin time is not set in the trace header (or maybe it is guaranteed to be set when we get to this function?), we can calculate travel time in a different way:
Either way, all required information is available to the _define_signal_and_noise_windows function.
I think 0.25 to 0.5 would be a reasonable range for the variable_window_length_factor, but we can probably test this.
We may also need to check if the window length does not extend beyond the trace length (but maybe this is not a problem).
Further, to determine the noise window length, we need to select
win_length_[p/s]
depending onconfig.wave_type
We should probably also warn users that variable win_length also requires longer noise windows, particularly if noise weighting is used. This may imply adjusting
config.noise_pre_time
...Let me know what you think,
Kris
Beta Was this translation helpful? Give feedback.
All reactions