-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Engagement Grid Editing #1635
Engagement Grid Editing #1635
Conversation
…utation It is already in `LanguageEngagementDetail` and doesn't need to be called out again.
Co-authored-by: Rob <rob_donigian@tsco.org>
This way users' change will be sent to the server immediately after selecting a new value without needing another interaction.
I have no idea why the version we were using had the native check disabled. The error message it produced with XHR polyfill was different from the native fetch. This prevented our error renderer from displaying a "failed to connect to API" error toast.
This handles nulls as a valid "unknown" option. Editing presents these three options. Filters are yet to be implemented
Co-authored-by: Rob <rob_donigian@tsco.org>
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Reworked #1629 to abstract the specific concepts into appropriate layers.