Created confirm dialog to check for empty variants by role

[atGit2021]

Andrew, I started a draft PR now that I have some functionality up and running, but it uses some "dummy" buttons which are not tied into the workflow. I'm also not sure of some of the other design changes that might be needed to incorporate/integrate this into the front end design standards. Let me know if you have any bandwidth to review/huddle or if you want me to reach out to Brent or Adam. Thank you sir.

Monday Ticket

[atGit2021]

I would like to remove the "any" type in the following function, const getEmptyResponsesForRole = (list: any, roles: Set<Role>) => { if (list.items.length === 0) return []; const responsesForRole = list.items[0]?.responses.filter((item: any) => { return item.variant.responsibleRole ? roles.has(item.variant.responsibleRole) : false; }); but the fragment type is not straight forward so I'm not sure how to create an interface or type to replace the "any" parameter type. Any suggestions are appreciated.

[bryanjnelson]

I think you may want this:

import { PromptResponseListFragment } from '../../../../../common/fragments/promptResponse.graphql';

…

const getEmptyResponsesForRole = (
    list: PromptResponseListFragment,
    roles: Set<Role>
  ) => {```

[atGit2021]

Hi Adam, I'm having a lint error issue that I can't seem to figure out. It's showing up [here].
(a54f3a1#:~:text=%7BhandleDialogCancel%7D-,onContinue%3D%7BhandleDialogConfirm%7D,-/%3E). I tried modifying the return type to 'Promise' up and down the call chain to see if that would resolve, but so far no success. Could you take a look and also review all the changes I made? Thank you.

[atGit2021]

@adam-soltech It's ready for your review now. Thank you.

[adam-soltech]

Hey Andre, thanks for asking for my review. Overall looks good. I added some comments when you have time.

[atGit2021]

Updated per your feedback, thank you @adam-soltech

[adam-soltech]

One last nit - otherwise lgtm. Good job! Thanks!

[adam-soltech]

LGTM - thanks for the opportunity to review

[atGit2021]

Thank you Adam. Hi @CarsonF, Please take a look when you get a chance and let me know if there are any other changes you want me to make?

[CarsonF]

Sorry for the huge delay in reviewing this 😞

We have a dynamic way to register steps already.
https://github.com/SeedCompany/cord-field/blob/master/src/scenes/ProgressReports/EditForm/Steps/index.ts#L9-L20
It would be better to re-use this to dynamically create your list here.
This could be iterated through just like ProgressReportStepper does.

Each step component could be updated to declare an isMissing function.
https://github.com/SeedCompany/cord-field/blob/master/src/scenes/ProgressReports/EditForm/Steps/step.types.ts#L4-L6

isMissing?: (report: ReportProp & { currentUserRoles: ReadonlySet<Role> }) => boolean;

Perhaps this could be called right after confirming the step is enabled, here

[atGit2021]

Thank you @CarsonF

[CarsonF]

@atGit2021 I renamed "missing" to "incomplete" - I think this is a better representation. I also tweaked the dialog: renamed the component to make sense, renamed the filename to match, tweaked the styling to not have duplicate <DialogContent>, dropped the dividers to be consistent with our theme & MD, used proper semantic markup for the lists.