chore: fix cleo typing (python-poetry#9100)

pyproject.toml

@@ -136,8 +136,6 @@ known-first-party = ["poetry"]
 known-third-party = ["poetry.core"]
 required-imports = ["from __future__ import annotations"]
 
-[tool.ruff.lint.per-file-ignores]
-"src/poetry/console/*" = ["RUF012"]  # Can't annotate properly until new version of Cleo
 
 [tool.mypy]
 files = "src, tests"

src/poetry/console/commands/add.py

@@ -2,7 +2,9 @@
 
 import contextlib
 
+from typing import TYPE_CHECKING
 from typing import Any
+from typing import ClassVar
 
 from cleo.helpers import argument
 from cleo.helpers import option
@@ -14,12 +16,19 @@
 from poetry.console.commands.installer_command import InstallerCommand
 
 
+if TYPE_CHECKING:
+    from cleo.io.inputs.argument import Argument
+    from cleo.io.inputs.option import Option
+
+
 class AddCommand(InstallerCommand, InitCommand):
     name = "add"
     description = "Adds a new dependency to <comment>pyproject.toml</>."
 
-    arguments = [argument("name", "The packages to add.", multiple=True)]
-    options = [
+    arguments: ClassVar[list[Argument]] = [
+        argument("name", "The packages to add.", multiple=True)
+    ]
+    options: ClassVar[list[Option]] = [
         option(
             "group",
             "-G",
@@ -95,7 +104,10 @@ class AddCommand(InstallerCommand, InitCommand):
 {examples}
 """
 
-    loggers = ["poetry.repositories.pypi_repository", "poetry.inspection.info"]
+    loggers: ClassVar[list[str]] = [
+        "poetry.repositories.pypi_repository",
+        "poetry.inspection.info",
+    ]
 
     def handle(self) -> int:
         from poetry.core.constraints.version import parse_constraint

src/poetry/console/commands/build.py

@@ -1,6 +1,8 @@
 from __future__ import annotations
 
 from pathlib import Path
+from typing import TYPE_CHECKING
+from typing import ClassVar
 
 from cleo.helpers import option
 
@@ -9,11 +11,15 @@
 from poetry.utils.helpers import remove_directory
 
 
+if TYPE_CHECKING:
+    from cleo.io.inputs.option import Option
+
+
 class BuildCommand(EnvCommand):
     name = "build"
     description = "Builds a package, as a tarball and a wheel by default."
 
-    options = [
+    options: ClassVar[list[Option]] = [
         option("format", "f", "Limit the format to either sdist or wheel.", flag=False),
         option(
             "clean",
@@ -35,7 +41,7 @@ class BuildCommand(EnvCommand):
         ),
     ]
 
-    loggers = [
+    loggers: ClassVar[list[str]] = [
         "poetry.core.masonry.builders.builder",
         "poetry.core.masonry.builders.sdist",
         "poetry.core.masonry.builders.wheel",

src/poetry/console/commands/cache/clear.py

@@ -2,6 +2,9 @@
 
 import os
 
+from typing import TYPE_CHECKING
+from typing import ClassVar
+
 from cleo.helpers import argument
 from cleo.helpers import option
 from packaging.utils import canonicalize_name
@@ -11,12 +14,21 @@
 from poetry.utils.cache import FileCache
 
 
+if TYPE_CHECKING:
+    from cleo.io.inputs.argument import Argument
+    from cleo.io.inputs.option import Option
+
+
 class CacheClearCommand(Command):
     name = "cache clear"
     description = "Clears a Poetry cache by name."
 
-    arguments = [argument("cache", description="The name of the cache to clear.")]
-    options = [option("all", description="Clear all entries in the cache.")]
+    arguments: ClassVar[list[Argument]] = [
+        argument("cache", description="The name of the cache to clear.")
+    ]
+    options: ClassVar[list[Option]] = [
+        option("all", description="Clear all entries in the cache.")
+    ]
 
     def handle(self) -> int:
         cache = self.argument("cache")

src/poetry/console/commands/check.py

@@ -2,6 +2,7 @@
 
 from typing import TYPE_CHECKING
 from typing import Any
+from typing import ClassVar
 
 from cleo.helpers import option
 
@@ -11,6 +12,8 @@
 if TYPE_CHECKING:
     from pathlib import Path
 
+    from cleo.io.inputs.option import Option
+
 
 class CheckCommand(Command):
     name = "check"
@@ -19,7 +22,7 @@ class CheckCommand(Command):
         " consistency with the poetry.lock file."
     )
 
-    options = [
+    options: ClassVar[list[Option]] = [
         option(
             "lock",
             None,

src/poetry/console/commands/command.py

@@ -2,6 +2,7 @@
 
 from typing import TYPE_CHECKING
 from typing import Any
+from typing import ClassVar
 
 from cleo.commands.command import Command as BaseCommand
 from cleo.exceptions import CleoValueError
@@ -13,7 +14,7 @@
 
 
 class Command(BaseCommand):
-    loggers: list[str] = []
+    loggers: ClassVar[list[str]] = []
 
     _poetry: Poetry | None = None
 

src/poetry/console/commands/config.py

@@ -6,6 +6,7 @@
 from pathlib import Path
 from typing import TYPE_CHECKING
 from typing import Any
+from typing import ClassVar
 from typing import cast
 
 from cleo.helpers import argument
@@ -19,19 +20,22 @@
 
 
 if TYPE_CHECKING:
+    from cleo.io.inputs.argument import Argument
+    from cleo.io.inputs.option import Option
+
     from poetry.config.config_source import ConfigSource
 
 
 class ConfigCommand(Command):
     name = "config"
     description = "Manages configuration settings."
 
-    arguments = [
+    arguments: ClassVar[list[Argument]] = [
         argument("key", "Setting key.", optional=True),
         argument("value", "Setting value.", optional=True, multiple=True),
     ]
 
-    options = [
+    options: ClassVar[list[Option]] = [
         option("list", None, "List configuration settings."),
         option("unset", None, "Unset configuration setting."),
         option("local", None, "Set/Get from the project's local configuration."),
@@ -48,7 +52,7 @@ class ConfigCommand(Command):
 
     <comment>poetry config --unset repo.foo</comment>"""
 
-    LIST_PROHIBITED_SETTINGS = {"http-basic", "pypi-token"}
+    LIST_PROHIBITED_SETTINGS: ClassVar[set[str]] = {"http-basic", "pypi-token"}
 
     @property
     def unique_config_values(self) -> dict[str, tuple[Any, Any]]:

src/poetry/console/commands/debug/resolve.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 from typing import TYPE_CHECKING
+from typing import ClassVar
 
 from cleo.helpers import argument
 from cleo.helpers import option
@@ -11,17 +12,19 @@
 
 
 if TYPE_CHECKING:
+    from cleo.io.inputs.argument import Argument
+    from cleo.io.inputs.option import Option
     from cleo.ui.table import Rows
 
 
 class DebugResolveCommand(InitCommand):
     name = "debug resolve"
     description = "Debugs dependency resolution."
 
-    arguments = [
+    arguments: ClassVar[list[Argument]] = [
         argument("package", "The packages to resolve.", optional=True, multiple=True)
     ]
-    options = [
+    options: ClassVar[list[Option]] = [
         option(
             "extras",
             "E",
@@ -34,7 +37,10 @@ class DebugResolveCommand(InitCommand):
         option("install", None, "Show what would be installed for the current system."),
     ]
 
-    loggers = ["poetry.repositories.pypi_repository", "poetry.inspection.info"]
+    loggers: ClassVar[list[str]] = [
+        "poetry.repositories.pypi_repository",
+        "poetry.inspection.info",
+    ]
 
     def handle(self) -> int:
         from cleo.io.null_io import NullIO

src/poetry/console/commands/env/info.py

@@ -1,21 +1,24 @@
 from __future__ import annotations
 
 from typing import TYPE_CHECKING
+from typing import ClassVar
 
 from cleo.helpers import option
 
 from poetry.console.commands.command import Command
 
 
 if TYPE_CHECKING:
+    from cleo.io.inputs.option import Option
+
     from poetry.utils.env import Env
 
 
 class EnvInfoCommand(Command):
     name = "env info"
     description = "Displays information about the current environment."
 
-    options = [
+    options: ClassVar[list[Option]] = [
         option("path", "p", "Only display the environment's path."),
         option(
             "executable", "e", "Only display the environment's python executable path."

src/poetry/console/commands/env/list.py

@@ -1,15 +1,24 @@
 from __future__ import annotations
 
+from typing import TYPE_CHECKING
+from typing import ClassVar
+
 from cleo.helpers import option
 
 from poetry.console.commands.command import Command
 
 
+if TYPE_CHECKING:
+    from cleo.io.inputs.option import Option
+
+
 class EnvListCommand(Command):
     name = "env list"
     description = "Lists all virtualenvs associated with the current project."
 
-    options = [option("full-path", None, "Output the full paths of the virtualenvs.")]
+    options: ClassVar[list[Option]] = [
+        option("full-path", None, "Output the full paths of the virtualenvs.")
+    ]
 
     def handle(self) -> int:
         from poetry.utils.env import EnvManager

src/poetry/console/commands/env/remove.py

@@ -1,16 +1,24 @@
 from __future__ import annotations
 
+from typing import TYPE_CHECKING
+from typing import ClassVar
+
 from cleo.helpers import argument
 from cleo.helpers import option
 
 from poetry.console.commands.command import Command
 
 
+if TYPE_CHECKING:
+    from cleo.io.inputs.argument import Argument
+    from cleo.io.inputs.option import Option
+
+
 class EnvRemoveCommand(Command):
     name = "env remove"
     description = "Remove virtual environments associated with the project."
 
-    arguments = [
+    arguments: ClassVar[list[Argument]] = [
         argument(
             "python",
             "The python executables associated with, or names of the virtual"
@@ -19,7 +27,7 @@ class EnvRemoveCommand(Command):
             multiple=True,
         )
     ]
-    options = [
+    options: ClassVar[list[Option]] = [
         option(
             "all",
             description=(

src/poetry/console/commands/env/use.py

@@ -1,15 +1,24 @@
 from __future__ import annotations
 
+from typing import TYPE_CHECKING
+from typing import ClassVar
+
 from cleo.helpers import argument
 
 from poetry.console.commands.command import Command
 
 
+if TYPE_CHECKING:
+    from cleo.io.inputs.argument import Argument
+
+
 class EnvUseCommand(Command):
     name = "env use"
     description = "Activates or creates a new virtualenv for the current project."
 
-    arguments = [argument("python", "The python executable to use.")]
+    arguments: ClassVar[list[Argument]] = [
+        argument("python", "The python executable to use.")
+    ]
 
     def handle(self) -> int:
         from poetry.utils.env import EnvManager

src/poetry/console/commands/init.py

@@ -3,6 +3,7 @@
 from pathlib import Path
 from typing import TYPE_CHECKING
 from typing import Any
+from typing import ClassVar
 from typing import Dict
 from typing import Mapping
 from typing import Union
@@ -17,6 +18,7 @@
 
 
 if TYPE_CHECKING:
+    from cleo.io.inputs.option import Option
     from packaging.utils import NormalizedName
     from poetry.core.packages.package import Package
     from tomlkit.items import InlineTable
@@ -32,7 +34,7 @@ class InitCommand(Command):
         "Creates a basic <comment>pyproject.toml</> file in the current directory."
     )
 
-    options = [
+    options: ClassVar[list[Option]] = [
         option("name", None, "Name of the package.", flag=False),
         option("description", None, "Description of the package.", flag=False),
         option("author", None, "Author name of the package.", flag=False),