Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement cosmic_text as the text renderer and editor #179

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Implement cosmic_text as the text renderer and editor #179

wants to merge 3 commits into from

Conversation

msparkles
Copy link
Contributor

@msparkles msparkles commented Jul 1, 2024 •
edited
Loading

Closes #95

@msparkles msparkles requested a review from LPGhatguy as a code owner July 1, 2024 16:21
@msparkles msparkles changed the title Implement cosmic_text as the text renderer and editor. Closes #95 Implement cosmic_text as the text renderer and editor Jul 1, 2024
@msparkles
Copy link
Contributor Author

msparkles commented Jul 2, 2024 •
edited
Loading

image

Weird text bug on yakui demo Fixed!

@msparkles
Copy link
Contributor Author

Unsure of why the tests are failing!

@msparkles msparkles mentioned this pull request Jul 3, 2024
Open
@msparkles
Copy link
Contributor Author

msparkles commented Jul 3, 2024 •
edited
Loading

Need input on the tests

Otherwise should be ready for review!

@msparkles msparkles requested a review from LPGhatguy July 13, 2024 04:07
@msparkles
Copy link
Contributor Author

msparkles commented Jul 13, 2024 •
edited
Loading

Hm! Either I'm doing something wrong here, or whatever #125 aims to fix is hitting me hard here.

It seems that if I switch to another page in my game, textboxes will happily reuse the contents of the old one selected.

@LPGhatguy
Copy link
Member

Even after #125 or a similar fix, you'll still run into that until we fix widget keys. More details in Discord!

Ideally, widgets are able to react to props changing so that it isn't a major issue to reuse widget state but sometimes that isn't possible.

@msparkles
Copy link
Contributor Author

we've made a branch that contains code to solve the issue. but it depends on this pr because we were too lazy to find a reprod on main that actually does have the issue, lol!

@msparkles msparkles mentioned this pull request Jul 17, 2024
Open
@msparkles
Copy link
Contributor Author

AAAaahhhhh. hi-dpi actually works now. This has become like 40 commits, god damn it

@msparkles
Copy link
Contributor Author

oops squashed them wrongly i think

@msparkles msparkles mentioned this pull request Sep 10, 2024
Open
@msparkles
Copy link
Contributor Author

msparkles commented Sep 24, 2024 •
edited
Loading

apparently the text fixes broke the height of texts on certain fonts, so the actual thing we should've done was to change the tests 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Awaiting requested review from Ralith Ralith is a code owner

@kanerogers kanerogers Awaiting requested review from kanerogers kanerogers is a code owner

@LPGhatguy LPGhatguy Awaiting requested review from LPGhatguy LPGhatguy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate using Cosmic Text
2 participants
@msparkles @LPGhatguy