Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some background-image underlines are too close #6

Open
Seanharrs opened this issue Jul 13, 2018 · 0 comments
Open

Some background-image underlines are too close #6

Seanharrs opened this issue Jul 13, 2018 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Seanharrs
Copy link
Owner

Some of the underlined elements on about.flipboard.com URLs have their underlines set too close to the text.

For example, these appear identically with or without the theme enabled:
acceptable
But these appear too close:
tooclose

This can be resolved by moving them out to their own separate rules, with different pixel measurements for each corner of the linear-gradient. For example:

a {
  background-image: linear-gradient(to top, rgba(0,0,0,0), rgba(0,0,0,0) 0px, #D22 0px, #D22 1px, rgba(0,0,0,0) 1px) !important;
  /* versus */
  background-image: linear-gradient(to top, rgba(0,0,0,0), rgba(0,0,0,0) 2px, #D22 2px, #D22 3px, rgba(0,0,0,0) 3px) !important;
}

The correct pixel values for each unique selector that is incorrect should be in Flipboard's CSS files.

@Seanharrs Seanharrs added enhancement New feature or request good first issue Good for newcomers labels Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant