Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy einsum and reshape can't have order=None #12

Open
yslan opened this issue Jan 1, 2023 · 1 comment
Open

numpy einsum and reshape can't have order=None #12

yslan opened this issue Jan 1, 2023 · 1 comment

Comments

@yslan
Copy link

yslan commented Jan 1, 2023

Not sure whether this related to the numpy version (mine is 1.24).
However, order = None fails since inside numpy it will try to do upper().

I suggest to set default order to 'C' unless we have decided to change everything into 'F'ortran ordering

def kron_2d(Sy, Sx, U, order=None):

def kron(Sz, Sy, Sx, U, order=None):

@thilinarmtb
Copy link
Contributor

Sounds good !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants