Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep file cache on shutdown. #62

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Keep file cache on shutdown. #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion component/file_cache/file_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,9 @@ func (c *FileCache) Stop() error {
log.Trace("Stopping component : %s", c.Name())

_ = c.policy.ShutdownPolicy()
_ = c.TempCacheCleanup()
if !c.allowNonEmpty {
_ = c.TempCacheCleanup()
foodprocessor marked this conversation as resolved.
Show resolved Hide resolved
}

fileCacheStatsCollector.Destroy()

Expand Down
2 changes: 1 addition & 1 deletion setup/baseConfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ file_cache:
low-threshold: <% disk space consumed which triggers eviction to stop when previously triggered by the high-threshold. Default - 60>
create-empty-file: true|false <create an empty file on container when create call is received from kernel>
allow-non-empty-temp: true|false <allow non empty temp directory at startup. Set true to persist local cache across reboots.>
cleanup-on-start: true|false <cleanup the temp directory on startup, if its not empty>
cleanup-on-start: true|false <cleanup the temp directory on startup, if it's not empty>
policy-trace: true|false <generate eviction policy logs showing which files will expire soon>
offload-io: true|false <by default libfuse will service reads/writes to files for better perf. Set to true to make file-cache component service read/write calls.>
sync-to-flush: true|false <sync call to a file will force upload of the contents to storage account. Default - true>
Expand Down
Loading