Improve Windows GUI Mount Error Handling #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use path.join instead of literal slashes.
foodprocessor
requested review from
Dabnsky,
Ferelith-maker and
jfantinhardesty
as code owners
foodprocessor
changed the title
Ferelith-maker
approved these changes
Dec 4, 2023
jfantinhardesty
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of Pull Request is this? (check all applicable)
Describe your changes in brief
Mount function now checks if mount directory was created successfully before reporting status back to the user. This should prevent mount from failing silently.
Add functions to handle subprocess consistently.
Status messages are appended to the contents of the status text field instead of replacing them.
Checklist
Related Issues