Size tracking component #423
Open
+1,799
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfantinhardesty
requested review from
Dabnsky,
Ferelith-maker and
foodprocessor
as code owners
foodprocessor
approved these changes
Jan 24, 2025
| } | ||
|
|
||
| var newSize int64 | ||
| attr, getAttrErr2 := st.NextComponent().GetAttr(internal.GetAttrOptions{Name: options.Handle.Path}) |
There was a problem hiding this comment.
Could we use the WriteFileOptions to figure out the new size without calling GetAttr again?
I think the new size would be whichever is larger: the old size or options.Offset + len(options.Data), right?
There was a problem hiding this comment.
Yeah, good idea to avoid an extra call. I will make that change.
Co-authored-by: Michael Habinsky <foodprocessor@users.noreply.github.com> Signed-off-by: James Fantin-Hardesty <24646452+jfantinhardesty@users.noreply.github.com>
…e into size-tracking-component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of Pull Request is this? (check all applicable)
Describe your changes in brief
This adds a new size tracker component which tracks the size of the mounted directory to prevent calls to the cloud to get the size of the mount. This in particular is useful when mounting subdirectories as there is no call in S3 to retrieve the size of the storage. This component goes in between the file_cache and attr_cache to track write information.
Checklist
Related Issues