Fix size test to run only for S3, cleanup tests for Windows

.github/workflows/code-coverage.yml

@@ -249,7 +249,7 @@ jobs:
           sleep 10
           ps -aux | grep cloudfuse
           cd test/e2e_tests
-          go test -v -timeout=7200s ./... -args -mnt-path=${{ env.MOUNT_DIR }} -tmp-path=${{ env.TEMP_DIR }}
+          go test -v -timeout=7200s ./... -args -mnt-path=${{ env.MOUNT_DIR }} -tmp-path=${{ env.TEMP_DIR }} -s3storage=true
           cd -
           sudo fusermount -u ${{ env.MOUNT_DIR }}
           sleep 5
@@ -293,7 +293,7 @@ jobs:
           sleep 10
           ps -aux | grep cloudfuse
           cd test/e2e_tests
-          go test -v -timeout=7200s ./... -args -mnt-path=${{ env.MOUNT_DIR }} -tmp-path=${{ env.TEMP_DIR }}
+          go test -v -timeout=7200s ./... -args -mnt-path=${{ env.MOUNT_DIR }} -tmp-path=${{ env.TEMP_DIR }} -s3storage=true
           cd -
           sudo fusermount -u ${{ env.MOUNT_DIR }}
           sleep 5

component/size_tracker/size_tracker.go

@@ -55,6 +55,7 @@ type SizeTrackerOptions struct {
 
 const compName = "size_tracker"
 const blockSize = int64(4096)
+const emptyDirSize = uint64(4096)
 const default_journal_name = "mount_size.dat"
 
 // Verification to check satisfaction criteria with Component Interface
@@ -118,12 +119,6 @@ func (st *SizeTracker) Priority() internal.ComponentPriority {
 func (st *SizeTracker) OnConfigChange() {
 }
 
-// Directory operations
-func (st *SizeTracker) DeleteDir(options internal.DeleteDirOptions) error {
-	// Libfuse only allows deleting empty directories, so we should not need to update the size here
-	return st.NextComponent().DeleteDir(options)
-}
-
 func (st *SizeTracker) RenameDir(options internal.RenameDirOptions) error {
 	// Rename dir should not allow renaming files into a directory that already exists so we should not
 	// need to update the size here.

component/size_tracker/size_tracker_test.go

@@ -31,6 +31,7 @@ import (
 	"os"
 	"path"
 	"path/filepath"
+	"runtime"
 	"strconv"
 	"strings"
 	"testing"
@@ -198,10 +199,13 @@ func (suite *sizeTrackerTestSuite) TestCreateFile() {
 	// Default is to not create empty files on create file to support immutable storage.
 	path := generateFileName()
 	options := internal.CreateFileOptions{Name: path}
-	_, err := suite.sizeTracker.CreateFile(options)
+	h, err := suite.sizeTracker.CreateFile(options)
 	suite.assert.NoError(err)
 	suite.assert.EqualValues(0, suite.sizeTracker.mountSize.GetSize())
 
+	err = suite.sizeTracker.CloseFile(internal.CloseFileOptions{Handle: h})
+	suite.assert.NoError(err)
+
 	err = suite.sizeTracker.DeleteFile(internal.DeleteFileOptions{Name: path})
 	suite.assert.NoError(err)
 }
@@ -277,6 +281,9 @@ func (suite *sizeTrackerTestSuite) TestWriteFileMultiple() {
 	suite.assert.NoError(err)
 	suite.assert.EqualValues(4*len(data), int(suite.sizeTracker.mountSize.GetSize()))
 
+	err = suite.sizeTracker.CloseFile(internal.CloseFileOptions{Handle: handle})
+	suite.assert.NoError(err)
+
 	err = suite.sizeTracker.DeleteFile(internal.DeleteFileOptions{Name: file})
 	suite.assert.NoError(err)
 }
@@ -362,6 +369,10 @@ func (suite *sizeTrackerTestSuite) TestRenameFile() {
 }
 
 func (suite *sizeTrackerTestSuite) TestRenameOpenFile() {
+	if runtime.GOOS == "windows" {
+		fmt.Println("Skipping test on Windows")
+		return
+	}
 	defer suite.cleanupTest()
 
 	src := "src2"
@@ -393,6 +404,10 @@ func (suite *sizeTrackerTestSuite) TestRenameOpenFile() {
 }
 
 func (suite *sizeTrackerTestSuite) TestRenameWriteFile() {
+	if runtime.GOOS == "windows" {
+		fmt.Println("Skipping test on Windows")
+		return
+	}
 	defer suite.cleanupTest()
 
 	src := "src3"
@@ -473,6 +488,10 @@ func (suite *sizeTrackerTestSuite) TestTruncateFileOpen() {
 }
 
 func (suite *sizeTrackerTestSuite) TestSymlink() {
+	if runtime.GOOS == "windows" {
+		fmt.Println("Skipping test on Windows")
+		return
+	}
 	defer suite.cleanupTest()
 	// Setup
 	file := generateFileName()