Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX app_status query for mlflow view #291

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apps/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

from .app_registry import APP_REGISTRY
from .helpers import create_instance_from_form
from .models import BaseAppInstance
from .tasks import delete_resource

logger = get_logger(__name__)
Expand Down Expand Up @@ -313,10 +314,10 @@ class SecretsView(View):
template = "apps/secrets_view.html"

def get(self, request, project, app_slug, app_id):
instance = APP_REGISTRY.get_orm_model(app_slug).objects.get(pk=app_id)
instance: BaseAppInstance = APP_REGISTRY.get_orm_model(app_slug).objects.get(pk=app_id)

username, password = None, None
if instance.app_status.status == "Running":
if instance.get_app_status() == "Running":
subdomain = instance.subdomain
username = subprocess.run(
(
Expand Down