Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS-1327 Add upload size in admin panel #285

Merged
merged 9 commits into from
Feb 26, 2025

Conversation

j-awada
Copy link
Contributor

@j-awada j-awada commented Feb 25, 2025

Description

https://scilifelab.atlassian.net/browse/SS-1327

The default upload size limit of Serve apps is 1MB. We want to allow the user to upload files with larger size by introducing the following changes:

  • adding a value for Nginx clientMaxBodySize in the serve charts of Serve apps (covered in this PR)
  • implementing an admin-only parameter to increase upload size upon user request

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have included, reviewed and executed tests (unit and end2end) to complement my changes
  • I have updated the related documentation (if necessary)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

Further comments

Anything else you think we should know before merging your code!

@j-awada j-awada added the enhancement Improvement of existing feature or request label Feb 25, 2025
@j-awada j-awada self-assigned this Feb 25, 2025
@j-awada j-awada requested a review from hamzaimran08 February 25, 2025 14:08
@j-awada j-awada marked this pull request as ready for review February 25, 2025 14:08
Copy link
Collaborator

@hamzaimran08 hamzaimran08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Good work.

@hamzaimran08 hamzaimran08 changed the title SS-1387 Add upload size in admin panel SS-1327 Add upload size in admin panel Feb 25, 2025
@j-awada j-awada changed the base branch from develop to ss-1220-refactor-app-status February 26, 2025 13:22
@j-awada j-awada merged commit 4027832 into ss-1220-refactor-app-status Feb 26, 2025
2 checks passed
@j-awada j-awada deleted the SS-1327-admin-upload-size branch February 26, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants