Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS-1204 harmonize frontend #278

Merged
merged 13 commits into from
Feb 19, 2025
Merged

SS-1204 harmonize frontend #278

merged 13 commits into from
Feb 19, 2025

Conversation

hamzaimran08
Copy link
Collaborator

@hamzaimran08 hamzaimran08 commented Feb 17, 2025

Description

This change relates to issue SS-1204. There are many front-end changes in this one but mainly the following parts have been changed

  • App Edit/Create forms
  • Navbar
  • App Cards on Public Apps page
  • Project Apps page
  • User profile and edit profile pages
  • Sign up and password change forms

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have included, reviewed and executed tests (unit and end2end) to complement my changes
  • I have updated the related documentation (if necessary)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

Further comments

Anything else you think we should know before merging your code!

@hamzaimran08 hamzaimran08 self-assigned this Feb 18, 2025
@hamzaimran08 hamzaimran08 marked this pull request as ready for review February 18, 2025 10:26
@hamzaimran08 hamzaimran08 added the enhancement Improvement of existing feature or request label Feb 18, 2025
Copy link
Contributor

@anondo1969 anondo1969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and it looks good to me. Excellent work :) .

@hamzaimran08 hamzaimran08 merged commit 74cca65 into develop Feb 19, 2025
2 of 3 checks passed
@hamzaimran08 hamzaimran08 deleted the SS-1204-harmonize-frontend branch February 19, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants