Ss 1179 add a unit test for the profile changes #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Viktor Sandström <v.sandstrom@icloud.com>
This reverts commit d321a3f.
removed comments Co-authored-by: Nikita Churikov <8545082+churnikov@users.noreply.github.com>
fixed the gap after hash sign Co-authored-by: Nikita Churikov <8545082+churnikov@users.noreply.github.com>
changed the comment text Co-authored-by: Nikita Churikov <8545082+churnikov@users.noreply.github.com>
churnikov
approved these changes
Oct 25, 2024
Thank you so much. |
removed the login_required decorator. Co-authored-by: Nikita Churikov <8545082+churnikov@users.noreply.github.com>
|
Added three unit tests for the validations of profile change values namely first_name, last_name, and department. First two tests (pass and fail) are for the user_edit_form (first_name and last name). The last one (pass) is for the profile_edit_form (department). It seems 'department' field is valid for any type of key inputs; hence only pass_validation test is written. |
anondo1969
deleted the
SS-1179-Add-a-unit-test-for-the-profile-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Source: https://scilifelab.atlassian.net/browse/SS-1179
Added three unit tests for the validations of profile change values namely first_name, last_name, and department. First two tests (pass and fail) are for the user_edit_form (first_name and last name). The last one (pass) is for the profile_edit_form (department). It seems 'department' field is valid for any type of key inputs; hence only pass_validation test is written.
Types of changes
Unit test
Checklist
If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.